Review 13.4 Merged

89718[TASK] Simplify LabelCapability

Oli Bartsch CR +2 V +2 Normal +72 −84 updated 06/12/25, 17:08

Commit message

The LabelCapability used `FieldTypeInterface`
objects instead of just the related field names.

This in the past (#106362) already required to
introduce the `SystemInternalFieldType` to
handle fields, not configured as TCA column,
e.g. `uid`.

Since it has been observed, that basically all
usages of the LabelCapability always access the
`getName()` method of the fields, this patch
now simplifies the LabelCapability by just
providing the configured field names.

There are only two places where the actual field
is evaluated. This is however easily possible
by just fetching the field via the TcaSchema
with `getField()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 10

Review log 57

  1. Oli Bartsch commented on patch set 1 06/12/25, 16:25

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php * typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php * typo3/sysext/backend/Classes/RecordList/DownloadRecordList.php * typo3/sysext/core/Classes/Tree/TableConfiguration/TreeDataProviderFactory.php * typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
  2. Oli Bartsch uploaded patch set 2 06/12/25, 16:32

  3. Oli Bartsch commented on patch set 2 06/12/25, 16:32

    This change is ready for review.
  4. core-ci voted on patch set 2 V +1 06/12/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80262

  5. core-ci voted on patch set 1 V -1 06/12/25, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80261

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 06/12/25, 17:08

  7. Oli Bartsch merged patch set 3 06/12/25, 17:08