Review 13.4 Merged

89752[TASK] Remove import of `RecordTableElement` in workspaces backend

Andreas Kienast CR +2 V +2 Easy +1 −2 updated 06/18/25, 08:07

Commit message

The import of `RecordTableElement` in the `@typo3/workspaces/backend`
module is only required as the code assumely needs to know the exact
type of an element returned by `querySelector()`.

The queried element `typo3-workspaces-record-table` already properly
declares itself in the `HTMLElementTagNameMap`, therefore
`querySelector()` is very well aware of the element being returned.

This allows us to remove the explicit type import.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 06/18/25, 07:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/18/25, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80456

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 06/18/25, 08:07

  4. Andreas Kienast merged patch set 2 06/18/25, 08:07