Review 13.4 Merged

89775[TASK] Remove superfluous is_string() check

Benjamin Franzke CR +2 V +2 Easy +2 −8 updated 06/19/25, 11:14

Commit message

The identifier argument has already a string type declaration, so
there is no need to check for a string again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 06/19/25, 11:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/19/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80502

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/19/25, 11:14

  4. Benjamin Franzke merged patch set 2 06/19/25, 11:14