Review 12.4 Abandoned

89919[TASK] Update to CKEditor 45.2.1

Andreas Kienast CR 0 V 0 Nightmare +2728 −2188 updated 07/02/25, 13:29

Commit message

The ckeditor bundle is updated to version 45.2.1. Due to breaking
changes [1], our own link UI needs some refactoring.

Commands:

  cd Build
  # lodash dependency was removed, load explicitly
  # (for now, we could drop it, but extensions may use it as a dep)
  npm install --save lodash-es@^4.17
  npm --prefix overrides/ckeditor5 version 45.2.1
  npm install --save ./overrides/ckeditor5 $(
    grep @ckeditor/ package.json | \
    grep -v @ckeditor/ckeditor5-dev-utils | \
    grep -v @ckeditor/ckeditor5-inspector | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@45.2.1/' \
  )
  npm install --save @ckeditor/ckeditor5-icons@^45.2.1
  npm run build

The new plugins "Emoji" and "Fullscreen" need more work, seperate
issues [2] [3] have been created for this as a follow-up.

[1] https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-45.html#ui-toolbar-refactoring
[2] https://forge.typo3.org/issues/106961
[3] https://forge.typo3.org/issues/106962

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 129

Show 109 more files

Review log 46

  1. Andreas Kienast commented on patch set 1 06/26/25, 14:52

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/Sass/element/typo3-rte-ckeditor-ckeditor5.scss * Build/Sources/TypeScript/rte-ckeditor/legacy/ckeditor5-bundle.ts * Build/Sources/TypeScript/rte-ckeditor/plugin/typo3-link.ts * Build/package-lock.json * Build/package.json * typo3/sysext/backend/Resources/Public/Css/backend.css * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-alignment.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-autoformat.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-basic-styles.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-block-quote.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-clipboard.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-code-block.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-core.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-classic.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-engine.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-enter.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-essentials.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-find-and-replace.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-font.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-heading.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-highlight.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-horizontal-line.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-html-support.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-indent.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-language.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-link.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-list.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-mention.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paragraph.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paste-from-office.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-remove-format.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-select-all.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-show-blocks.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-source-editing.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-special-characters.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-style.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-table.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-typing.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-ui.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-undo.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-upload.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-utils.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-watchdog.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-widget.js * typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-word-count.js * typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/legacy/ckeditor5-bundle.js * typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/typo3-link.js
  2. core-ci voted on patch set 1 V -1 06/26/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80992

  3. Andreas Kienast uploaded patch set 2 V -1 06/26/25, 15:04

  4. Andreas Kienast marked it ready for review 06/26/25, 15:04

  5. core-ci voted on patch set 2 V +1 06/26/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80993

  6. Benjamin Franzke abandoned the change 07/02/25, 13:29