Review 13.4 Merged

89920[TASK] Move record preview logic to PreviewUriBuilder

Benni Mack CR +2 V +2 Hard +201 −416 updated 07/04/25, 07:41

Commit message

All of the code in `EditDocumentController` is
moved into the PreviewUriBuilder. Therefore,
the `PreviewUriBuilder` does now provide the
logic of creating preview uris for all kind
of records globally.

This means, components like the list view,
the context menu do now properly provide the
preview option for custom records.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Wand +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Benni Mack commented on patch set 1 06/26/25, 15:05

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php * typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php
  2. Benni Mack commented on patch set 2 06/26/25, 15:08

    Published edit on patch set 1.
  3. core-ci voted on patch set 2 V +1 06/26/25, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80996

  4. Benni Mack marked it ready for review 06/26/25, 15:21

  5. core-ci voted on patch set 1 V -1 06/26/25, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80994

  6. Oliver Wand voted on patch set 2 CR +1 07/04/25, 06:29

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 07/04/25, 07:41

  8. Oli Bartsch merged patch set 3 07/04/25, 07:41