Review 13.4 Merged

89937[TASK] Do not use full TYPO3 context in early permission checks

Stefan Bürk CR +2 V +2 Easy +5 −8 updated 06/27/25, 15:06

Commit message

`PermissionsCheck` verifies whether the configured database
has the required permissions. For this purpose, it is not
necessary to use TYPO3's Connection and QueryBuilder.

Using QueryBuilder too early can lead to issues, since it
applies default restrictions that rely on TCA and the
TcaSchemaFactory, which may not be available during early
initialization.

This change replaces QueryBuilder with a plain Doctrine
connection for simple permission checks, avoiding unnecessary
dependencies on TYPO3 internals at this stage.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 06/27/25, 14:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/27/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81079

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 06/27/25, 15:06

  4. Stefan Bürk merged patch set 2 06/27/25, 15:06