Review 13.4 Merged

89982[BUGFIX] Show proper line breaks in workspaces comment view

Benjamin Franzke CR +2 V +2 Normal +43 −12 updated 07/03/25, 10:43

Commit message

Also avoid double html-escaping values both on server
and client side. The jQuery to lit migration missed to
disable service-side htmlspecialchars, when lit was used
and threfore secure escaping has been applied in the
JavaScript renderer.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 35

  1. Benjamin Franzke commented on patch set 1 07/03/25, 10:08

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Service/GridDataService.php
  2. Benjamin Franzke uploaded patch set 2 07/03/25, 10:09

    Resolve Conflicts
  3. core-ci voted on patch set 1 V -1 07/03/25, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81277

  4. core-ci voted on patch set 2 V +1 07/03/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81278

  5. Benjamin Franzke merged patch set 3 07/03/25, 10:43