Review 13.4 Merged

89986[TASK] Update to CKEditor 45.2.1

Andreas Kienast CR +2 V +2 Nightmare +2512 −2032 updated 07/04/25, 08:02

Commit message

The ckeditor bundle is updated to version 45.2.1. Due to breaking
changes [1], our own link UI needs some refactoring.

Commands:

  cd Build
  # lodash dependency was removed, load explicitly
  # (for now, we could drop it, but extensions may use it as a dep)
  npm install --save lodash-es@^4.17
  npm --prefix overrides/ckeditor5 version 45.2.1
  npm install --save ./overrides/ckeditor5 $(
    grep @ckeditor/ package.json | \
    grep -v @ckeditor/ckeditor5-dev-utils | \
    grep -v @ckeditor/ckeditor5-inspector | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@45.2.1/' \
  )
  npm install --save @ckeditor/ckeditor5-icons@^45.2.1
  npm run build

The new plugins "Emoji" and "Fullscreen" need more work, seperate
issues [2] [3] have been created for this as a follow-up.

[1] https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-45.html#ui-toolbar-refactoring
[2] https://forge.typo3.org/issues/106961
[3] https://forge.typo3.org/issues/106962

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 129

Show 109 more files

Review log 34

  1. Andreas Kienast commented on patch set 1 07/04/25, 07:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/04/25, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81312

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 07/04/25, 08:02

  4. Andreas Kienast merged patch set 2 07/04/25, 08:02