Review main Merged

90056[BUGFIX] Use translated option labels in form finisher output

Josua Vogel CR +2 V +2 Expert +1349 −163 updated 08/27/26, 09:01

Commit message

Finisher options substitute {elementIdentifier} placeholders with the
submitted value of a form element. A select, radio button, multi
checkbox or country select therefore contributed its stored option key
where a human reads the result: the subject of an email said "Request
from mr" while the summary table below it said "Request from Mister".

Value resolution now lives in a dedicated FormValueResolver, shared by
the RenderFormValue ViewHelper and AbstractFinisher, so the summary
page, the email body and the subject line agree on what a submitted
value looks like. A form element contributes its own representation by
implementing ProcessableValueFormElementInterface, which Date,
FileUpload, CountrySelect and the new GenericOptionableFormElement do.

A finisher opts a single option into that resolution by reading it
with parseOptionAsDisplayValue() instead of parseOption(). The email
finisher does so for subject, title, message and senderName, the
confirmation finisher for message, the flash message finisher for
messageBody and messageTitle. Every other option keeps the submitted
value, which is what the column mappings and the whereClause of the
SaveToDatabase finisher, the redirect targets and the email addresses
beside the sender name need.

The two new element classes extend GenericFormElement rather than
AbstractFormElement, so an instanceof check against the class these
elements used before keeps matching.

An array interpolated into a longer string is now joined instead of
aborting the finisher; an array carrying an object that cannot be
converted to a string still throws.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Josua Vogel +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 3

Files 26

Show 6 more files

Review log 64101

Show 4676 earlier messages
  1. Josua Vogel uploaded patch set 1 07/11/25, 17:29

  2. Josua Vogel commented on patch set 1 07/11/25, 17:34

    I am unsure whether the conversion of the methods from the ViewHelper to the FormElement object is a valid change for the product or whether methods may not simply be moved because extension authors may use the API of the classes. Feedback welcome!
  3. core-ci voted on patch set 1 V -1 07/11/25, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81618

  4. Josua Vogel uploaded patch set 2 V -1 07/11/25, 17:48

  5. core-ci voted on patch set 2 V -1 07/11/25, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81619

  6. Josua Vogel uploaded patch set 3 V -1 07/11/25, 17:58

  7. core-ci voted on patch set 3 V +1 07/11/25, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81620

  8. Garvin Hicking commented on patch set 3 07/11/25, 19:42

    Reply

    I'd say since the VH is final, and the methods only callable from within, that's fair.
  9. Garvin Hicking commented on patch set 3 07/11/25, 19:45

    Reply

    OTOH requiring to implement processElementValue in the interface is a breaking change. I'd tend to only do this in main, not v12/v13...
  10. Josua Vogel commented on patch set 3 07/11/25, 19:54

    Reply

    yes I‘m not sure, where to put the code. the value is „connected“ to the form element, but an utility class would be another possibility
  11. Garvin Hicking commented on patch set 3 07/11/25, 20:45

    Reply

    (I only read this patch on mobile and need to check properly in the IDE and will try to give better feedback)
  12. Josua Vogel commented on patch set 3 07/21/25, 08:49

    Reply

    Hi @garvin@hick.ing, have you had time to look at this fix yet?
  13. Garvin Hicking commented on patch set 3 07/21/25, 09:47

    Reply

    I had a few more looks and I felt this was rather 'heavy-handed' and also would mean special kind of processing e.g. in the abstract for "processElementValue" which would then make the abstract aware of specific implementations, which is IMO a boundary we should not cross. It would mean touching the abstract for any future kind of element that would need processing values. I feel like this should be a fature-patch for main only, and make changes in the interface and new methods to make each element be able to process transformations for the subject line. But I'm not proficient enough in EXT:form to really gauge the impact and possibilities of this. :-/
  14. Josua Vogel uploaded patch set 4 V +1 07/22/25, 11:21

  15. core-ci voted on patch set 4 V -1 07/22/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82120

  16. Josua Vogel uploaded patch set 5 V -1 07/22/25, 17:06

  17. core-ci voted on patch set 5 V +1 07/22/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82133

  18. Garvin Hicking commented on patch set 5 07/22/25, 18:01

    Reply

    Thanks so much for iterating on this patch - I do believe this is getting much more promising. I'm unsure about a possible breaking impact on v13 for this change though, maybe this will need to be a feature. I'd like to wait for feedback on @benjamin.kott@outlook.com for this (after DevDays stress) if that's ok with you!
  19. Josua Vogel uploaded patch set 6 V +1 07/22/25, 18:45

  20. Josua Vogel uploaded patch set 7 07/22/25, 18:46

  21. Josua Vogel uploaded patch set 8 07/22/25, 18:48

  22. core-ci voted on patch set 6 V -1 07/22/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82138

  23. core-ci voted on patch set 7 V -1 07/22/25, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82139

  24. core-ci voted on patch set 8 V -1 07/22/25, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82140

  25. Josua Vogel uploaded patch set 9 V -1 07/24/25, 14:28

  26. core-ci voted on patch set 9 V -1 07/24/25, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82250

  27. Josua Vogel uploaded patch set 10 V -1 07/24/25, 14:45

  28. core-ci voted on patch set 10 V +1 07/24/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82255

  29. Josua Vogel updated the commit message in patch set 11 V +1 07/24/25, 16:06

  30. core-ci voted on patch set 11 V +1 07/24/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82266

  31. Josua Vogel uploaded patch set 12 V +1 11/25/25, 15:58

  32. core-ci voted on patch set 12 V -1 11/25/25, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90966

  33. Josua Vogel uploaded patch set 13 V -1 11/25/25, 16:58

  34. core-ci voted on patch set 13 V +1 11/25/25, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90969

  35. Christian Rath-Ulrich voted on patch set 13 CR +1 01/21/26, 15:36

  36. Josua Vogel commented on patch set 13 01/21/26, 15:44

    Reply

    @garvin@hick.ing, @benjamin.kott@outlook.com I don't see any breaking changes here.
  37. Sven Liebert voted on patch set 13 CR +1 V +1 01/23/26, 10:40

  38. Josua Vogel uploaded patch set 14 CR +1 V +1 01/28/26, 12:00

  39. core-ci voted on patch set 14 V +1 01/28/26, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94498

  40. Sven Liebert voted on patch set 14 CR +1 V +1 01/28/26, 12:30

  41. Josua Vogel updated the commit message in patch set 15 CR +1 V +1 02/06/26, 19:03

  42. Sven Liebert voted on patch set 15 CR +1 V +1 02/06/26, 19:05

  43. core-ci voted on patch set 15 V +1 02/06/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95336

  44. Josua Vogel uploaded patch set 16 CR +1 V +1 04/23/26, 09:10

  45. core-ci voted on patch set 16 V -1 04/23/26, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101012

  46. Josua Vogel uploaded patch set 17 V -1 04/23/26, 09:30

  47. Josua Vogel uploaded patch set 18 04/23/26, 09:34

  48. core-ci voted on patch set 18 V +1 04/23/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101014

  49. core-ci voted on patch set 17 V -1 04/23/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101013

  50. Josua Vogel updated the commit message in patch set 19 V +1 04/23/26, 10:16

  51. core-ci voted on patch set 19 V +1 04/23/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101021

  52. Josua Vogel rebased onto patch set 20 V +1 05/07/26, 06:27

  53. core-ci voted on patch set 20 V +1 05/07/26, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101648

  54. Josua Vogel rebased onto patch set 21 V +1 05/22/26, 12:07

  55. core-ci voted on patch set 21 V +1 05/22/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102352

  56. Josua Vogel uploaded patch set 22 V +1 06/05/26, 13:44

  57. Josua Vogel uploaded patch set 23 06/05/26, 13:47

  58. core-ci voted on patch set 23 V +1 06/05/26, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103037

  59. core-ci voted on patch set 22 V -1 06/05/26, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103035

  60. Christian Rath-Ulrich commented on patch set 23 06/13/26, 20:42

    RenderFormValueViewHelper.php:93

    The refactor removes the former generic object handling (DateTime, File, __toString fallback) from this ViewHelper. processValue() now only delegates to ProcessableValueFormElementInterface. Elements such as Date still implement StringableFormElementInterface only (see Date.php), not ProcessableValueFormElementInterface. As a result, {formValue.processedValue} in email templates may receive a raw \DateTime object instead of a formatted string, which can lead to empty output or runtime errors.
  61. Josua Vogel uploaded patch set 24 V +1 06/15/26, 06:35

  62. core-ci voted on patch set 24 V -1 06/15/26, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103502

  63. Josua Vogel uploaded patch set 25 V -1 06/15/26, 06:53

  64. core-ci voted on patch set 25 V -1 06/15/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103504

  65. Josua Vogel uploaded patch set 26 V -1 06/15/26, 07:14

  66. Josua Vogel commented on patch set 26 06/15/26, 07:15

    RenderFormValueViewHelper.php:93 Reply

    Thank you for finding this bug. I've fixed it, tidied up the code a bit, and double-checked to make sure it doesn't break
  67. core-ci voted on patch set 26 V -1 06/15/26, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103507

  68. Josua Vogel uploaded patch set 27 06/15/26, 07:54

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  69. core-ci voted on patch set 27 V -1 06/15/26, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103510

  70. Josua Vogel rebased onto patch set 28 V -1 06/16/26, 05:11

  71. core-ci voted on patch set 28 V -1 06/16/26, 05:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103543

  72. Josua Vogel rebased onto patch set 29 V -1 06/16/26, 09:16

  73. core-ci voted on patch set 29 V +1 06/16/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103556

  74. Josua Vogel rebased onto patch set 30 V +1 06/19/26, 05:01

  75. core-ci voted on patch set 30 V +1 06/19/26, 05:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103656

  76. Josua Vogel rebased onto patch set 31 V +1 06/24/26, 21:20

  1. core-ci voted on patch set 31 V +1 06/24/26, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103837

  2. Josua Vogel uploaded patch set 32 V +1 07/26/26, 14:54

  3. core-ci voted on patch set 32 V -1 07/26/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105423

  4. Josua Vogel uploaded patch set 33 V -1 07/26/26, 15:16

  5. core-ci voted on patch set 33 V +1 07/26/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105425

  6. Sven Liebert voted on patch set 33 CR +1 V +1 08/06/26, 20:59

  7. Christian Rath-Ulrich voted on patch set 33 CR +1 V +1 08/08/26, 19:14

  8. Josua Vogel uploaded patch set 34 CR +1 V +1 08/26/26, 13:55

  9. core-ci voted on patch set 34 V -1 08/26/26, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107152

  10. Benjamin Kott uploaded patch set 35 V -1 08/26/26, 15:12

  11. core-ci voted on patch set 35 V +1 08/26/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107154

  12. Benjamin Kott uploaded patch set 36 V +1 08/26/26, 15:19

  13. Benjamin Kott voted on patch set 36 CR +1 V +1 08/26/26, 15:20

  14. core-ci voted on patch set 36 V +1 08/26/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107155

  15. Garvin Hicking voted on patch set 36 CR +1 V +1 08/26/26, 16:54

  16. Sven Liebert voted on patch set 36 CR +1 V +1 08/26/26, 17:15

  17. Josua Vogel commented on patch set 36 CR -1 08/27/26, 06:16

    I'd like to test it again
  18. Benjamin Kott uploaded patch set 37 CR +1 V +1 08/27/26, 07:34

  19. core-ci voted on patch set 37 V +1 08/27/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107222

  20. Josua Vogel commented on patch set 37 08/27/26, 08:01

    Reply

    benji fixed a few things. thx! I'm satisfied with the current solution and haven't encountered any problems.
  21. Josua Vogel voted on patch set 37 CR +1 V +1 08/27/26, 08:01

  22. Benjamin Kott voted on patch set 37 CR +1 V +1 08/27/26, 08:02

  23. Sven Liebert voted on patch set 37 CR +1 V +1 08/27/26, 08:07

  24. Benjamin Kott voted on patch set 37 CR +2 V +2 08/27/26, 08:25

  25. Benjamin Kott merged patch set 38 08/27/26, 09:01