90056[BUGFIX] Use translated option labels in form finisher output
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Josua Vogel +1
- Sven Liebert +1
-
Verified V +2 Done
- Benjamin Kott +2
- Josua Vogel +1
- Sven Liebert +1
- core-ci +1 CI
Issues 3
Files 26
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-106903-FormElementValueResolutionInFinishers.rstnew+84 −0
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+130 −31
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+7 −4
- typo3/sysext/form/Classes/Domain/Finishers/FlashMessageFinisher.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/CountrySelect.phpnew+35 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/Date.php+10 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+28 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/GenericOptionableFormElement.phpnew+53 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/ProcessableValueFormElementInterface.phpnew+31 −0
- typo3/sysext/form/Classes/Service/FormValueResolver.phpnew+111 −0
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php2+3 −107
- typo3/sysext/form/Configuration/Form/Base/FormElements/CountrySelect.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiCheckbox.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiSelect.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/RadioButton.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/SingleSelect.yaml+1 −1
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php+199 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/FlashMessageFinisherTest.phpnew+129 −0
Show 6 more files
- typo3/sysext/form/Tests/Functional/Domain/Finishers/SaveToDatabaseFinisherTest.php+131 −0
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderFormValueViewHelperTest.php+72 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/Fixtures/AbstractFinisherFixture.php+5 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+90 −4
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+77 −0
- typo3/sysext/form/Tests/Unit/Service/FormValueResolverTest.phpnew+146 −0
Review log 64101
Show 4676 earlier messages
-
Josua Vogel uploaded patch set 1 07/11/25, 17:29
-
Josua Vogel commented on patch set 1 07/11/25, 17:34
I am unsure whether the conversion of the methods from the ViewHelper to the FormElement object is a valid change for the product or whether methods may not simply be moved because extension authors may use the API of the classes. Feedback welcome! -
core-ci voted on patch set 1 V -1 07/11/25, 17:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81618
-
Josua Vogel uploaded patch set 2
V -107/11/25, 17:48 -
core-ci voted on patch set 2 V -1 07/11/25, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81619
-
Josua Vogel uploaded patch set 3
V -107/11/25, 17:58 -
core-ci voted on patch set 3 V +1 07/11/25, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81620
-
Garvin Hicking commented on patch set 3 07/11/25, 19:42
Reply
I'd say since the VH is final, and the methods only callable from within, that's fair. -
Garvin Hicking commented on patch set 3 07/11/25, 19:45
Reply
OTOH requiring to implement processElementValue in the interface is a breaking change. I'd tend to only do this in main, not v12/v13... -
Josua Vogel commented on patch set 3 07/11/25, 19:54
Reply
yes I‘m not sure, where to put the code. the value is „connected“ to the form element, but an utility class would be another possibility -
Garvin Hicking commented on patch set 3 07/11/25, 20:45
Reply
(I only read this patch on mobile and need to check properly in the IDE and will try to give better feedback) -
Josua Vogel commented on patch set 3 07/21/25, 08:49
Reply
Hi @garvin@hick.ing, have you had time to look at this fix yet? -
Garvin Hicking commented on patch set 3 07/21/25, 09:47
Reply
I had a few more looks and I felt this was rather 'heavy-handed' and also would mean special kind of processing e.g. in the abstract for "processElementValue" which would then make the abstract aware of specific implementations, which is IMO a boundary we should not cross. It would mean touching the abstract for any future kind of element that would need processing values. I feel like this should be a fature-patch for main only, and make changes in the interface and new methods to make each element be able to process transformations for the subject line. But I'm not proficient enough in EXT:form to really gauge the impact and possibilities of this. :-/ -
Josua Vogel uploaded patch set 4
V +107/22/25, 11:21 -
core-ci voted on patch set 4 V -1 07/22/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82120
-
Josua Vogel uploaded patch set 5
V -107/22/25, 17:06 -
core-ci voted on patch set 5 V +1 07/22/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82133
-
Garvin Hicking commented on patch set 5 07/22/25, 18:01
Reply
Thanks so much for iterating on this patch - I do believe this is getting much more promising. I'm unsure about a possible breaking impact on v13 for this change though, maybe this will need to be a feature. I'd like to wait for feedback on @benjamin.kott@outlook.com for this (after DevDays stress) if that's ok with you! -
Josua Vogel uploaded patch set 6
V +107/22/25, 18:45 -
Josua Vogel uploaded patch set 7 07/22/25, 18:46
-
Josua Vogel uploaded patch set 8 07/22/25, 18:48
-
core-ci voted on patch set 6 V -1 07/22/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82138
-
core-ci voted on patch set 7 V -1 07/22/25, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82139
-
core-ci voted on patch set 8 V -1 07/22/25, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82140
-
Josua Vogel uploaded patch set 9
V -107/24/25, 14:28 -
core-ci voted on patch set 9 V -1 07/24/25, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82250
-
Josua Vogel uploaded patch set 10
V -107/24/25, 14:45 -
core-ci voted on patch set 10 V +1 07/24/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82255
-
Josua Vogel updated the commit message in patch set 11
V +107/24/25, 16:06 -
core-ci voted on patch set 11 V +1 07/24/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82266
-
Josua Vogel uploaded patch set 12
V +111/25/25, 15:58 -
core-ci voted on patch set 12 V -1 11/25/25, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90966
-
Josua Vogel uploaded patch set 13
V -111/25/25, 16:58 -
core-ci voted on patch set 13 V +1 11/25/25, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90969
-
Christian Rath-Ulrich voted on patch set 13 CR +1 01/21/26, 15:36
-
Josua Vogel commented on patch set 13 01/21/26, 15:44
Reply
@garvin@hick.ing, @benjamin.kott@outlook.com I don't see any breaking changes here. -
Sven Liebert voted on patch set 13 CR +1 V +1 01/23/26, 10:40
-
Josua Vogel uploaded patch set 14
CR +1V +101/28/26, 12:00 -
core-ci voted on patch set 14 V +1 01/28/26, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94498
-
Sven Liebert voted on patch set 14 CR +1 V +1 01/28/26, 12:30
-
Josua Vogel updated the commit message in patch set 15
CR +1V +102/06/26, 19:03 -
Sven Liebert voted on patch set 15 CR +1 V +1 02/06/26, 19:05
-
core-ci voted on patch set 15 V +1 02/06/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95336
-
Josua Vogel uploaded patch set 16
CR +1V +104/23/26, 09:10 -
core-ci voted on patch set 16 V -1 04/23/26, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101012
-
Josua Vogel uploaded patch set 17
V -104/23/26, 09:30 -
Josua Vogel uploaded patch set 18 04/23/26, 09:34
-
core-ci voted on patch set 18 V +1 04/23/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101014
-
core-ci voted on patch set 17 V -1 04/23/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101013
-
Josua Vogel updated the commit message in patch set 19
V +104/23/26, 10:16 -
core-ci voted on patch set 19 V +1 04/23/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101021
-
Josua Vogel rebased onto patch set 20
V +105/07/26, 06:27 -
core-ci voted on patch set 20 V +1 05/07/26, 06:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101648
-
Josua Vogel rebased onto patch set 21
V +105/22/26, 12:07 -
core-ci voted on patch set 21 V +1 05/22/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102352
-
Josua Vogel uploaded patch set 22
V +106/05/26, 13:44 -
Josua Vogel uploaded patch set 23 06/05/26, 13:47
-
core-ci voted on patch set 23 V +1 06/05/26, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103037
-
core-ci voted on patch set 22 V -1 06/05/26, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103035
-
Christian Rath-Ulrich commented on patch set 23 06/13/26, 20:42
RenderFormValueViewHelper.php:93The refactor removes the former generic object handling (DateTime, File, __toString fallback) from this ViewHelper. processValue() now only delegates to ProcessableValueFormElementInterface. Elements such as Date still implement StringableFormElementInterface only (see Date.php), not ProcessableValueFormElementInterface. As a result, {formValue.processedValue} in email templates may receive a raw \DateTime object instead of a formatted string, which can lead to empty output or runtime errors. -
Josua Vogel uploaded patch set 24
V +106/15/26, 06:35 -
core-ci voted on patch set 24 V -1 06/15/26, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103502
-
Josua Vogel uploaded patch set 25
V -106/15/26, 06:53 -
core-ci voted on patch set 25 V -1 06/15/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103504
-
Josua Vogel uploaded patch set 26
V -106/15/26, 07:14 -
Josua Vogel commented on patch set 26 06/15/26, 07:15
RenderFormValueViewHelper.php:93ReplyThank you for finding this bug. I've fixed it, tidied up the code a bit, and double-checked to make sure it doesn't break -
core-ci voted on patch set 26 V -1 06/15/26, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103507
-
Josua Vogel uploaded patch set 27 06/15/26, 07:54
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 27 V -1 06/15/26, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103510
-
Josua Vogel rebased onto patch set 28
V -106/16/26, 05:11 -
core-ci voted on patch set 28 V -1 06/16/26, 05:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103543
-
Josua Vogel rebased onto patch set 29
V -106/16/26, 09:16 -
core-ci voted on patch set 29 V +1 06/16/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103556
-
Josua Vogel rebased onto patch set 30
V +106/19/26, 05:01 -
core-ci voted on patch set 30 V +1 06/19/26, 05:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103656
-
Josua Vogel rebased onto patch set 31
V +106/24/26, 21:20
-
core-ci voted on patch set 31 V +1 06/24/26, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103837
-
Josua Vogel uploaded patch set 32
V +107/26/26, 14:54 -
core-ci voted on patch set 32 V -1 07/26/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105423
-
Josua Vogel uploaded patch set 33
V -107/26/26, 15:16 -
core-ci voted on patch set 33 V +1 07/26/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105425
-
Sven Liebert voted on patch set 33 CR +1 V +1 08/06/26, 20:59
-
Christian Rath-Ulrich voted on patch set 33 CR +1 V +1 08/08/26, 19:14
-
Josua Vogel uploaded patch set 34
CR +1V +108/26/26, 13:55 -
core-ci voted on patch set 34 V -1 08/26/26, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107152
-
Benjamin Kott uploaded patch set 35
V -108/26/26, 15:12 -
core-ci voted on patch set 35 V +1 08/26/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107154
-
Benjamin Kott uploaded patch set 36
V +108/26/26, 15:19 -
Benjamin Kott voted on patch set 36 CR +1 V +1 08/26/26, 15:20
-
core-ci voted on patch set 36 V +1 08/26/26, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107155
-
Garvin Hicking voted on patch set 36 CR +1 V +1 08/26/26, 16:54
-
Sven Liebert voted on patch set 36 CR +1 V +1 08/26/26, 17:15
-
Josua Vogel commented on patch set 36 CR -1 08/27/26, 06:16
I'd like to test it again -
Benjamin Kott uploaded patch set 37
CR +1V +108/27/26, 07:34 -
core-ci voted on patch set 37 V +1 08/27/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107222
-
Josua Vogel commented on patch set 37 08/27/26, 08:01
Reply
benji fixed a few things. thx! I'm satisfied with the current solution and haven't encountered any problems. -
Josua Vogel voted on patch set 37 CR +1 V +1 08/27/26, 08:01
-
Benjamin Kott voted on patch set 37 CR +1 V +1 08/27/26, 08:02
-
Sven Liebert voted on patch set 37 CR +1 V +1 08/27/26, 08:07
-
Benjamin Kott voted on patch set 37 CR +2 V +2 08/27/26, 08:25
-
Benjamin Kott merged patch set 38 08/27/26, 09:01