Review 13.4 Merged

90083[TASK] Avoid deleting the settings.yaml file from a site folder

Benjamin Franzke CR +2 V +2 Easy +14 −7 updated 07/17/25, 09:20

Commit message

When resetting all settings to their default value via the settings
editor, an empty settings result map is to be persisted and a
site-specific custom settings.yaml becomes obsolete.

The current pragmatic approach to delete the settings.yaml file
worked for most cases, but we can not assume that a settings.yaml can
always be recreated as-is later on, when custom settings should be
stored again. The settings file might be symlinked, mounted or
associated with specific file system permissions, and should therefore
never be deleted.

To address these requirements the file contents are now only wiped,
without deleting the file itself.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke commented on patch set 1 07/17/25, 07:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/17/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81810

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 07/17/25, 09:19

  4. Benjamin Franzke merged patch set 2 07/17/25, 09:20