Review 12.4 Merged

90094[TASK] Update `phpstan/phpstan` to 2.1.18

Garvin Hicking CR +2 V +2 Easy +20 −8 updated 07/18/25, 14:37

Commit message

Executed commands:

    composer require --dev phpstan/phpstan:^2.1.18 -W
    ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 913

  1. Garvin Hicking commented on patch set 1 07/18/25, 10:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/18/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81924

  3. Garvin Hicking uploaded patch set 2 V -1 07/18/25, 10:36

    baseline
  4. core-ci voted on patch set 2 V -1 07/18/25, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81925

  5. Garvin Hicking uploaded patch set 3 V -1 07/18/25, 11:10

    proper baseline update
  6. core-ci voted on patch set 3 V +1 07/18/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81927

  7. Oliver Klee commented on patch set 3 07/18/25, 12:09

    Shouldn't this also have changes to the `composer.json` (if `composer require` was used instead of `composer update`)?
  8. Garvin Hicking uploaded patch set 4 V +1 07/18/25, 12:17

    include composer json
  9. core-ci voted on patch set 4 V +1 07/18/25, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81930

  10. Garvin Hicking commented on patch set 4 07/18/25, 12:26

    Reply

    Yes, my bad, I did not properly stash the file. Fixed, thanks!
  11. Oliver Klee voted on patch set 4 CR +1 V +1 07/18/25, 13:12

  12. Garvin Hicking voted on patch set 4 CR +2 V +2 07/18/25, 14:37

  13. Garvin Hicking merged patch set 5 07/18/25, 14:37