90094[TASK] Update `phpstan/phpstan` to 2.1.18
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 3
Review log 913
-
Garvin Hicking commented on patch set 1 07/18/25, 10:24
Cherry Picked from branch main. -
core-ci voted on patch set 1 V -1 07/18/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81924
-
Garvin Hicking uploaded patch set 2
V -107/18/25, 10:36baseline -
core-ci voted on patch set 2 V -1 07/18/25, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81925
-
Garvin Hicking uploaded patch set 3
V -107/18/25, 11:10proper baseline update -
core-ci voted on patch set 3 V +1 07/18/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81927
-
Oliver Klee commented on patch set 3 07/18/25, 12:09
Shouldn't this also have changes to the `composer.json` (if `composer require` was used instead of `composer update`)? -
Garvin Hicking uploaded patch set 4
V +107/18/25, 12:17include composer json -
core-ci voted on patch set 4 V +1 07/18/25, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81930
-
Garvin Hicking commented on patch set 4 07/18/25, 12:26
Reply
Yes, my bad, I did not properly stash the file. Fixed, thanks! -
Oliver Klee voted on patch set 4 CR +1 V +1 07/18/25, 13:12
-
Garvin Hicking voted on patch set 4 CR +2 V +2 07/18/25, 14:37
-
Garvin Hicking merged patch set 5 07/18/25, 14:37