Review 13.4 Merged

90116[BUGFIX] Ensure request body is writable in ServerRequestInstruction

Oli Bartsch CR +2 V +2 Normal +61 −2 updated 07/22/25, 09:55

Commit message

When deserializing a ServerRequestInstruction
from array data, the body stream was recreated
using the originally stored stream mode (e.g. "rb").
This caused a RuntimeException when attempting to
write to a read-only stream during deserialization.

This patch ensures the stream is always recreated
with mode "w+b" to allow writing. The mode is no
longer serialized via jsonSerialize, as it is
irrelevant and may cause issues on reconstruction.

This issue typically did not occur in Core usage,
as many claims (e.g. from the user management module)
are GET requests with data passed via the query string.
However, custom extensions using POST requests with
a body payload were affected.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch commented on patch set 1 07/22/25, 09:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/22/25, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82112

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 07/22/25, 09:54

  4. Oli Bartsch merged patch set 2 07/22/25, 09:55