Review 13.4 Merged

90141[BUGFIX] Initialize change publishers for undefined form properties

Benjamin Franzke CR +2 V +2 Easy +12 −1 updated 07/24/25, 14:15

Commit message

The EXT:form model concept [1] sends change events (via
EXT:form `PublisherSubscriber`) whenever a property is changed
and uses these events for dirty-state tracking of the form editor
interface.

The interface can be used to edit existing properties, but also allows
to add new properties (like a description) to a form element, that
does not have a description yet.

Due to the nature of the form event model, these changes where not
detected, because changes to model object properties where only
"tracked" if they have a default value. Properties like
"elementDescription" do not have a default and therefore the
form element initialization now registers property change publishers
for all properties that can possibly be configured
by the form inspector (called "editors").

[1] https://docs.typo3.org/permalink/typo3-cms-form:concepts-formeditor-basicjavascriptconcepts-formelementmodel

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 07/24/25, 13:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/24/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82245

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 07/24/25, 14:15

  4. Benjamin Franzke merged patch set 2 07/24/25, 14:15