Review 12.4 Merged

90170[BUGFIX] Set correct data-mode for file selection

Markus Klein CR +2 V +2 Easy +2 −2 updated 07/28/25, 09:20

Commit message

Set data-mode to "file" in case "sys_file"
is to be selected in a TCA group field. This
prevents an empty record browser, which can
be tested with the group fields in
`tx_styleguide_elements_imagemanipulation`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Markus Klein commented on patch set 1 07/28/25, 08:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/28/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82418

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 07/28/25, 09:16

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 07/28/25, 09:20

  5. Oli Bartsch merged patch set 2 07/28/25, 09:20