Review 13.4 Merged

90181[BUGFIX] Make Install Tool AJAX error handling resilient to JS errors

Georg Ringer CR +2 V +2 Easy +3 −3 updated 07/29/25, 06:25

Commit message

If (for some reason) there's a JavaScript error while doing
an AJAX action in an Install Tool module modal, it will just
end up freezing because `error.response` is not set, as
there potentially never was a response.

This change adds null-checks to the response property in the
AJAX error handling and also shows the JS error message in the
"Ajax error" collapsible to inform the user about the issue.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 07/29/25, 06:11

    Cherry Picked from branch main.
  2. Georg Ringer voted on patch set 1 CR +2 V +2 07/29/25, 06:12

  3. core-ci voted on patch set 1 V +1 07/29/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82465

  4. Georg Ringer merged patch set 2 07/29/25, 06:25