Review 13.4 Merged

90216[BUGFIX] Load JavaScript importmaps of custom settings types

Benjamin Franzke CR +2 V +2 Easy +7 −3 updated 08/01/25, 09:26

Commit message

Ensure that the JavaScript importmap configuration of custom settings
type providers is loaded inside the settings editor by preloading
all settings types, that will be rendered inside the editor.
This also improves performance of the initial rendering and allows
to drop the inline spinner, which is actually just visible for
a few milliseconds and therefore more distracting than helpful.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benjamin Franzke commented on patch set 1 08/01/25, 08:57

    Cherry Picked from branch main.
  2. Benjamin Franzke marked it work in progress 08/01/25, 08:57

  3. core-ci voted on patch set 1 V +1 08/01/25, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82618

  4. Benjamin Franzke commented on patch set 2 V +1 08/01/25, 09:13

    Cherry Picked from branch main.
  5. Benjamin Franzke voted on patch set 2 CR +2 V +2 08/01/25, 09:13

  6. core-ci voted on patch set 2 V +1 08/01/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82620

  7. Benjamin Franzke merged patch set 3 08/01/25, 09:26