Review main Ready for review

90262[BUGFIX] Provide same structure for same event

Daniel Siepmann CR 0 V 0 Easy +30 −1 updated 11/13/26, 14:36

Commit message

The event `AppendLinkHandlerElementsEvent` within
`TypolinkTagSoftReferenceParser` missed the `matchString` within
`$elements` which was provided in the existing event within
`TypolinkSoftReferenceParser`.

This is now streamlined to provide the same structure
to the same event listeners. Links not resolved by any
listener are still not reported as matched.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/90262/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/90262/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Merge conflicts 1

Issues 2

Files 2

Review log 1422

  1. Daniel Siepmann uploaded patch set 1 08/07/25, 12:27

  2. Daniel Siepmann commented on patch set 1 08/07/25, 12:29

    TypolinkTagSoftReferenceParser.php:129

    I'm unsure about this part as well, as this is differently implemented within `TypolinkSoftReferenceParser`. An error is added in that case, this is missing here right now, let me know if I should add it as well.
  3. core-ci voted on patch set 1 V -1 08/07/25, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82857

  4. Daniel Siepmann uploaded patch set 2 V -1 08/07/25, 13:36

  5. core-ci voted on patch set 2 V +1 08/07/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82858

  6. Georg Ringer commented on patch set 2 08/07/25, 14:04

    please either use TASK or BUGFIX, not sure what suits better but also not that important TBH
  7. Benni Mack updated the commit message in patch set 3 V +1 08/07/25, 21:44

  8. core-ci voted on patch set 3 V +1 08/07/25, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82948

  9. Benni Mack commented on patch set 3 08/08/25, 07:00

    Reply

    Done

    TypolinkTagSoftReferenceParser.php:129 Reply Unresolved

    let's add the error as well
  10. Daniel Siepmann uploaded patch set 4 V +1 08/20/25, 09:29

  11. core-ci voted on patch set 4 V -1 08/20/25, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83666

  12. Daniel Siepmann marked it work in progress 08/21/25, 06:08

  13. Daniel Siepmann rebased onto patch set 5 V -1 09/02/25, 17:56

  14. core-ci voted on patch set 5 V -1 09/02/25, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84271

  15. Daniel Siepmann rebased onto patch set 6 V -1 09/25/25, 15:39

  16. core-ci voted on patch set 6 V -1 09/25/25, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85531

  17. Georg Ringer uploaded patch set 7 V -1 09/30/26, 18:56

  18. Georg Ringer commented on patch set 7 09/30/26, 18:57

    This change is ready for review.
  19. Georg Ringer rebased onto patch set 8 09/30/26, 19:03

  20. core-ci voted on patch set 7 V +1 09/30/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109685

  21. core-ci voted on patch set 8 V +1 09/30/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109686

  22. Georg Ringer rebased onto patch set 9 V +1 11/13/26, 14:36