90497[BUGFIX] Show online media headline in File Selector
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- Stefan Froemken +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1011
-
Oli Bartsch uploaded patch set 1 08/28/25, 07:08
-
core-ci voted on patch set 1 V +1 08/28/25, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83930
-
Stefan Froemken commented on patch set 1 CR +1 V +1 08/29/25, 08:59
"File Selector"...for me it's the "File Browser". All classes are named "FileBrowser". For me the "File Selector" is the window of the file selector when I access my local files on my computer. But yes, The headline on top of the FileBrowser is "File Selector". WHY?!?! Nevertheless, patch works, looks good -
Garvin Hicking voted on patch set 1 CR +1 V +1 08/29/25, 09:07
-
Garvin Hicking commented on patch set 1 08/29/25, 09:09
Georg had this as a dupe: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90505 that aimed for 12.4 too...? -
Oli Bartsch commented on patch set 1 08/29/25, 09:30
Reply
Does not look like a priortiy bugfix tbh. -
Georg Ringer commented on patch set 1 08/29/25, 12:09
no priority, but helps users in 12.4, it won't break anything. -
Georg Ringer voted on patch set 1 CR +1 V +1 08/29/25, 12:09
-
Oli Bartsch voted on patch set 1 CR +2 V +2 08/29/25, 12:51
-
Oli Bartsch merged patch set 2 08/29/25, 12:52
-
Benni Mack commented on patch set 2 08/29/25, 12:58
Reply
I want to remind you to a) only backport things to v12 that are critical or security-related or where you take the responsibility and b) you are sure it works on v12. We really really really need to focus on v14 and to work on other things that need to go in. If we open up this discussion again and again, we're wasting our own energies that we could put in v14. FYI @georg.ringer@gmail.com