Review main Merged

90539[BUGFIX] Consider already existing _computed in raw record

Nikita Hovratov CR +2 V +2 Normal +70 −1 updated 09/30/25, 10:31

Commit message

This patch adds support to read and build ComputedProperties
back from the _computed array.

There are cases where the raw record passed to RecordFactory
comes from the RawRecord->toArray() result. This array does
not possess the old computed property keys, but the newer
_computed array.

An example for such a case is:
- User adds page-content data processor to fetch records
- User renders each Record in column with f:cObject
- The rendering definition uses RecordFactory again to resolve relations
  from the data array passed to the ViewHelper.

The second RecordFactory call would result in wrong relations being
resolved if _computed is not considered.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 2232

Show 47 earlier messages
  1. Nikita Hovratov uploaded patch set 1 09/02/25, 09:27

  2. core-ci voted on patch set 1 V -1 09/02/25, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84226

  3. Nikita Hovratov marked it work in progress 09/02/25, 09:52

  4. Nikita Hovratov uploaded patch set 2 V -1 09/02/25, 10:06

  5. core-ci voted on patch set 2 V -1 09/02/25, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84229

  6. Nikita Hovratov uploaded patch set 3 V -1 09/02/25, 10:27

  7. core-ci voted on patch set 3 V +1 09/02/25, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84234

  1. Nikita Hovratov updated the commit message in patch set 4 V +1 09/02/25, 10:45

  2. Nikita Hovratov marked it ready for review 09/02/25, 10:45

  3. core-ci voted on patch set 4 V +1 09/02/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84236

  4. Benni Mack commented on patch set 4 09/02/25, 11:44

    RecordFactory.php:194

    shouldn't we also unset _computed like below?
  5. Nikita Hovratov uploaded patch set 5 V +1 09/02/25, 12:06

  6. Nikita Hovratov commented on patch set 5 09/02/25, 12:06

    RecordFactory.php:194 Reply

    Done
  7. core-ci voted on patch set 5 V +1 09/02/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84244

  8. André Buchmann voted on patch set 5 CR +1 V +1 09/04/25, 17:54

  9. Stefan Froemken commented on patch set 5 09/05/25, 09:11

    Shouldn't we add a test to check against the recursive use of extractComputedProperties?
  10. Nikita Hovratov rebased onto patch set 6 CR +1 V +1 09/23/25, 09:26

  11. core-ci voted on patch set 6 V +1 09/23/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85376

  12. Oli Bartsch commented on patch set 6 09/23/25, 12:52

    Reply

    I had the same concerns looking at this. However this might even be a problem already without this patch.
  13. Nikita Hovratov uploaded patch set 7 V +1 09/24/25, 10:22

  14. Nikita Hovratov commented on patch set 7 09/24/25, 10:24

    Reply

    I have added a test now, to showcase the forth and back transformation of RawRecord and computed properties.
  15. core-ci voted on patch set 7 V -1 09/24/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85444

  16. Nikita Hovratov uploaded patch set 8 V -1 09/24/25, 10:37

  17. core-ci voted on patch set 8 V +1 09/24/25, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85445

  18. Nikita Hovratov rebased onto patch set 9 V +1 09/30/25, 09:20

  19. core-ci voted on patch set 9 V +1 09/30/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85738

  20. Benni Mack commented on patch set 10 V +1 09/30/25, 10:06

    Published edit on patch set 9.
  21. Oli Bartsch commented on patch set 10 CR +1 V +1 09/30/25, 10:07

    Reply

    Done
  22. core-ci voted on patch set 10 V +1 09/30/25, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85744

  23. Benni Mack voted on patch set 10 CR +1 V +1 09/30/25, 10:29

  24. Oli Bartsch voted on patch set 10 CR +2 V +2 09/30/25, 10:31

  25. Oli Bartsch merged patch set 11 09/30/25, 10:31