Review 13.4 Merged

90584[TASK] Do not call non static test methods statically

Helmut Hummel CR +2 V +2 Expert +1044 −1024 updated 09/05/25, 22:36

Commit message

PHPUnit 11 changed some of the TestCase methods,
to not be static any more.
See: https://github.com/sebastianbergmann/phpunit/issues/5213

This change in PHPUnit is not directly reflected in
PHPCsFixer yet, but our config of the fixer, that we already use
can be changed, so that the non static method calls in our tests
are rewritten.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 173

Show 153 more files

Review log 68

  1. Helmut Hummel commented on patch set 1 09/05/25, 15:11

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseParentPageRowTest.php * typo3/sysext/core/Tests/Functional/Configuration/RichtextTest.php * typo3/sysext/core/Tests/Functional/Database/Query/Restriction/AbstractRestrictionContainerTest.php * typo3/sysext/core/Tests/Functional/Database/Query/Restriction/LimitToTablesRestrictionContainerTest.php * typo3/sysext/core/Tests/Unit/Resource/FolderTest.php * typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php * typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php * typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/CountryConverterTest.php * typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php * typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php * typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php * typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php * typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php * typo3/sysext/impexp/Tests/Functional/Command/ExportCommandTest.php
  2. Helmut Hummel uploaded patch set 2 09/05/25, 15:17

  3. Helmut Hummel marked it ready for review 09/05/25, 15:17

  4. core-ci voted on patch set 1 V -1 09/05/25, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84479

  5. core-ci voted on patch set 2 V +1 09/05/25, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84480

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/05/25, 18:43

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 09/05/25, 22:36

  8. Stefan Bürk merged patch set 3 09/05/25, 22:36