90584[TASK] Do not call non static test methods statically
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 173
- Build/php-cs-fixer/config.php+22 −2
- typo3/sysext/adminpanel/Tests/Functional/Modules/PreviewModuleTest.php+1 −1
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php+6 −6
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+3 −3
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php+3 −3
- typo3/sysext/adminpanel/Tests/Unit/Service/ModuleLoaderTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+2 −2
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexProcessTest.php+7 −7
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaInputPlaceholdersTest.php+6 −6
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Configuration/BackendUserConfigurationTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/Container/ListOfFieldsContainerTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OnTheFlyTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseParentPageRowTest.php+7 −7
Show 153 more files
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/EvaluateDisplayConditionsTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFolderTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+14 −14
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutCollectionTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+2 −2
- typo3/sysext/beuser/Tests/Functional/ViewHelpers/MfaStatusViewHelperTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/FileBackendTest.php+34 −34
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Imaging/ImageMagickFileTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+5 −5
- typo3/sysext/core/Tests/Functional/Resource/OnlineMedia/Processing/PreviewProcessingTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+2 −2
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconForRecordViewHelperTest.php+2 −2
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconViewHelperTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Cache/Frontend/VariableFrontendTest.php+13 −13
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+17 −17
- typo3/sysext/core/Tests/Unit/Command/Descriptor/TextDescriptorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+22 −22
- typo3/sysext/core/Tests/Unit/Configuration/ExtensionConfigurationTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Configuration/RichtextTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/PasswordHashFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/CompositeExpressionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+28 −28
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/AbstractRestrictionContainerTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/LimitToTablesRestrictionContainerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+81 −81
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Database/RelationHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+5 −5
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkTagSoftReferenceParserTest.php+4 −4
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+4 −4
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php+6 −6
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Imaging/GraphicalFunctionsTest.php+2 −2
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractProcessorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Middleware/CacheTagsAttributeTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Middleware/VerifyHostHeaderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Event/AfterVideoPreviewFetchedEventTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Processing/LocalPreviewHelperTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+17 −17
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/AbstractFileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Session/SessionManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −2
- typo3/sysext/dashboard/Tests/Unit/DependencyInjection/DashboardWidgetPassTest.php+10 −10
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php+6 −6
- typo3/sysext/extbase/Tests/Functional/Utility/LocalizationUtilityTest.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/CollectionValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/ConjunctionValidatorTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+15 −15
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+28 −28
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+37 −37
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/DateTimeConverterTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/FloatConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Service/CacheServiceTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+10 −10
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+9 −9
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+9 −9
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+7 −7
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php+5 −5
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php+5 −5
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.php+3 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/UriViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Unit/Core/Cache/FluidTemplateCacheTest.php+4 −4
- typo3/sysext/fluid/Tests/Unit/View/AbstractTemplateViewTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+8 −8
- typo3/sysext/form/Tests/Functional/EventListener/DataStructureIdentifierListenerTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.php+5 −5
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/Renderable/RenderableVariantTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+7 −7
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/RequestHandlerTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+9 −9
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+17 −17
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+52 −52
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+21 −21
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+3 −3
- typo3/sysext/impexp/Tests/Functional/Command/ExportCommandTest.php+17 −17
- typo3/sysext/impexp/Tests/Functional/Command/ImportCommandTest.php+7 −7
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+1 −1
- typo3/sysext/install/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+4 −4
- typo3/sysext/install/Tests/Functional/Updates/BackendGroupsExplicitAllowDenyMigrationTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+4 −4
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+7 −7
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+15 −15
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+11 −11
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+17 −17
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkOrDirectoryNodeTest.php+7 −7
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+5 −5
- typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php+2 −2
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+23 −23
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+11 −11
- typo3/sysext/redirects/Tests/Unit/FormDataProvider/ValuePickerItemDataProviderTest.php+2 −2
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+2 −2
- typo3/sysext/seo/Tests/Unit/HrefLang/HrefLangGeneratorTest.php+2 −2
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+3 −3
Review log 68
-
Helmut Hummel commented on patch set 1 09/05/25, 15:11
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseParentPageRowTest.php * typo3/sysext/core/Tests/Functional/Configuration/RichtextTest.php * typo3/sysext/core/Tests/Functional/Database/Query/Restriction/AbstractRestrictionContainerTest.php * typo3/sysext/core/Tests/Functional/Database/Query/Restriction/LimitToTablesRestrictionContainerTest.php * typo3/sysext/core/Tests/Unit/Resource/FolderTest.php * typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php * typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php * typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/CountryConverterTest.php * typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php * typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php * typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php * typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php * typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php * typo3/sysext/impexp/Tests/Functional/Command/ExportCommandTest.php -
Helmut Hummel uploaded patch set 2 09/05/25, 15:17
-
Helmut Hummel marked it ready for review 09/05/25, 15:17
-
core-ci voted on patch set 1 V -1 09/05/25, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84479
-
core-ci voted on patch set 2 V +1 09/05/25, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84480
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/05/25, 18:43
-
Stefan Bürk voted on patch set 2 CR +2 V +2 09/05/25, 22:36
-
Stefan Bürk merged patch set 3 09/05/25, 22:36