Review 13.4 Merged

90638[TASK] Improve a11y with aria-invalid attributes on FormEngine fields

Benjamin Kott CR +2 V +2 Easy +2 −1 updated 09/09/25, 10:49

Commit message

With this patch, fields rendered in FormEngine are now marked with
an "aria-invalid=true|false" HTML-tag attribute to improve accessibility.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Benjamin Kott commented on patch set 1 09/09/25, 09:17

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js
  2. Benjamin Kott uploaded patch set 2 09/09/25, 09:19

  3. Benjamin Kott marked it ready for review 09/09/25, 09:19

  4. core-ci voted on patch set 1 V -1 09/09/25, 09:27 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84682

  5. core-ci voted on patch set 2 V -1 09/09/25, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84683

  6. Benjamin Kott uploaded patch set 3 V -1 09/09/25, 09:33

  7. core-ci voted on patch set 3 V +1 09/09/25, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84686

  8. Benjamin Kott voted on patch set 3 CR +2 V +2 09/09/25, 10:49

  9. Benjamin Kott merged patch set 4 09/09/25, 10:49