Review 13.4 Merged

90650[TASK] Extend allowed list of uploadable text/misc files

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 09/09/25, 20:28

Commit message

The default configuration for `textfile_ext` is extended to allow
upload and the plain-text recognition of the following file types
in the file list (for editing a file):

* json
* md
* rst
* rtf
* srt

Also, the list of files for `miscfile_ext` is extended to
allow upload of common file formats for setups where
`security.system.enforceAllowedFileExtensions` is enabled,
to provide convenience for editors in uploading files
that are common for web CMS systems:

* 7z, doc, docm, docx, dot, dotm, dotx, epub, gz, ics, mobi,
  odp, ods, odt, potm, potx, ppam, pps, ppsm, ppsx, ppt, pptm,
  pptx, rar, sldm, sldx, tar, vcard, vcf, xlam, xls, xlsb, xlsm
  xlsx, xlt, xltm, xltx

This allows to enable said security flag more easily for maintainers,
without denying too many file types that are broadly used.

Please note:

1. This adjusts the default list of `textfile_ext` and `miscfile_ext`
   only for installations that have no custom configuration.

2. This addition makes the listed text files editable from the
   file list. Since these are defined as ASCII files, this is
   considered to not have side-effects.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 6

Files 1

Review log 811

  1. Garvin Hicking commented on patch set 1 09/09/25, 19:01

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Configuration/DefaultConfiguration.php
  2. Garvin Hicking commented on patch set 2 09/09/25, 19:03

    Published edit on patch set 1.
  3. Garvin Hicking commented on patch set 3 09/09/25, 19:04

    Published edit on patch set 2.
  4. core-ci voted on patch set 1 V -1 09/09/25, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84741

  5. Garvin Hicking commented on patch set 3 09/09/25, 19:09

    This change is ready for review.
  6. core-ci voted on patch set 2 V +1 09/09/25, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84742

  7. core-ci voted on patch set 3 V +1 09/09/25, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84743

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/09/25, 19:42

  9. Oli Bartsch voted on patch set 3 CR +1 V +1 09/09/25, 19:45

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 09/09/25, 20:28

  11. Garvin Hicking merged patch set 4 09/09/25, 20:28