Review 13.4 Merged

90654[BUGFIX] Allow editing site settings without root page being present

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 09/10/25, 12:55

Commit message

If a site is configured for a non-existing root page id, an exception is
thrown when trying to edit site settings. Although the configured root
page should exist, especially during development it might be possible
that this is not the case (yet).

With this patch, this behavior is now hardened: A configured root page
is no longer expected to actually exist, and related meta information is
not populated to the docheader component in this case.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 09/10/25, 12:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/10/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84776

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 09/10/25, 12:54

  4. Garvin Hicking merged patch set 2 09/10/25, 12:55