Review 12.4 Merged

90688[BUGFIX] Fix url check in GeneralUtility::sanitizeLocalUrl

Benjamin Franzke CR +2 V +2 Easy +29 −5 updated 09/15/25, 13:21

Commit message

The url check introduced via the patch
"Fix open redirection via GeneralUtility::sanitizeLocalUrl"
was to restrictive with respect to blank spaces.

Instead the check is divided into 2 cases, which now
allows blank spaces, when encoded properly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Benjamin Franzke commented on patch set 1 09/15/25, 12:56

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
  2. Benjamin Franzke uploaded patch set 2 09/15/25, 12:57

  3. Benjamin Franzke voted on patch set 2 CR +2 V +2 09/15/25, 12:59

  4. core-ci voted on patch set 2 V +1 09/15/25, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84987

  5. Benjamin Franzke merged patch set 3 09/15/25, 13:21