Review 13.4 Merged

90711[BUGFIX] Fix FAL getFileReferenceData method return signature

Georg Ringer CR +2 V +2 Easy +14 −3 updated 09/17/25, 18:37

Commit message

The `ResourceFactory->getFileReferenceData()` method executes a
QueryBuilder query which may return false on empty data. The
return type of that method though did not allow a `false` return.

The only consumer of the method in `ResourceFactory` later on only
checks for `!is_array()` to throw an exception.

This patch now ensures the proper exception can be thrown in case
of a non-found FileReference UID.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 09/17/25, 18:25

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/17/25, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85092

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/17/25, 18:37

  4. Georg Ringer merged patch set 2 09/17/25, 18:37