Review main Merged

90721[TASK] Introduce new internal API to generate a cache busting URI

Helmut Hummel CR +2 V +2 Normal +196 −43 updated 09/22/25, 20:32

Commit message

The new API is already used in
`GeneralUtility::createVersionNumberedFilename()`, but this method will
be deprecated in a subsequent change, which will replace all usages with
a new URL generation strategy.

The new API is kept internal as it is likely to be changed along the
way.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 913

  1. Helmut Hummel uploaded patch set 1 09/18/25, 20:40

  2. core-ci voted on patch set 1 V -1 09/18/25, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85131

  3. Oliver Klee updated the commit message in patch set 2 V -1 09/19/25, 06:36

  4. core-ci voted on patch set 2 V -1 09/19/25, 06:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85149

  5. Helmut Hummel uploaded patch set 3 V -1 09/19/25, 07:06

  6. Helmut Hummel updated the commit message in patch set 4 09/19/25, 07:08

  7. core-ci voted on patch set 4 V +1 09/19/25, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85151

  8. core-ci voted on patch set 3 V +1 09/19/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85150

  9. Benni Mack voted on patch set 4 CR +1 09/22/25, 07:40

  10. Benni Mack commented on patch set 4 V +1 09/22/25, 08:08

    CacheBustingUri.php:27

    I think this is fine for now, as it is just internal for the time being. In the future, I'd like to move this to our own UriFactory in one of the future iterations.
  11. Georg Ringer voted on patch set 4 CR +1 V +1 09/22/25, 19:04

  12. Helmut Hummel voted on patch set 4 CR +2 V +2 09/22/25, 20:32

  13. Helmut Hummel merged patch set 5 09/22/25, 20:32