Review 13.4 Merged

90789[BUGFIX] Use full row to check permissions deleting a record

Steffen Mächtel CR +2 V +2 Easy +1 −1 updated 11/10/25, 15:13

Commit message

The DataHandler loads all rows which are to be leaded and requires
the full row. Otherwise later permission checks in
`BackendUserAuthentication::recordEditAccessInternals` leads to an error message
`ERROR: The "languageField" field named "sys_languge_uid" was not found in testing record`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Steffen Mächtel uploaded patch set 1 09/24/25, 15:43

  2. Steffen Mächtel updated the commit message in patch set 2 09/24/25, 15:44

  3. core-ci voted on patch set 1 V +1 09/24/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85459

  4. core-ci voted on patch set 2 V +1 09/24/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85460

  5. Elias Häußler commented on patch set 2 CR -1 10/14/25, 12:12

    The related change for `main` (https://review.typo3.org/c/Packages/TYPO3.CMS/+/90790) looks good and should be backported as-is for v13. Otherwise, we have a superfluous additional DB query in `\TYPO3\CMS\Core\DataHandling\DataHandler::deleteRecord`. I'll take care.
  6. Elias Häußler commented on patch set 3 CR -1 V +1 10/14/25, 12:12

    Cherry Picked from branch main.
  7. Georg Ringer commented on patch set 3 10/14/25, 12:13

  8. Elias Häußler commented on patch set 3 10/14/25, 12:17

    Reply

    Yes, 90790 (main) and this one (13.4) are in sync now.
  9. core-ci voted on patch set 3 V +1 10/14/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86625

  10. Josef Glatz voted on patch set 3 CR +1 V +1 11/10/25, 13:34

  11. Benni Mack voted on patch set 3 CR +2 V +2 11/10/25, 15:13

  12. Benni Mack merged patch set 4 11/10/25, 15:13