Review main Merged

90796[TASK] Use symfony configurator for backend router

Benjamin Franzke CR +2 V +2 Normal +68 −40 updated 11/03/25, 20:28

Commit message

Service providers serve(d) us well, but we want to limit their use
to services that are actually needed in failsafe/installtool
context and therefore use symfony onboard utilities to configure
services instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1623

  1. Benjamin Franzke uploaded patch set 1 09/25/25, 11:37

  2. core-ci voted on patch set 1 V -1 09/25/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85507

  3. core-ci voted on patch set 1 V +1 09/25/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85507

  4. Benjamin Franzke uploaded patch set 2 V +1 10/01/25, 11:06

  5. core-ci voted on patch set 2 V -1 10/01/25, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85804

  6. Benjamin Franzke uploaded patch set 3 V -1 10/02/25, 07:24

  7. core-ci voted on patch set 3 V +1 10/02/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85874

  8. Benjamin Franzke marked it work in progress 10/06/25, 08:56

  9. Benjamin Franzke uploaded patch set 4 V +1 10/29/25, 14:35

  10. Benjamin Franzke marked it ready for review 10/29/25, 14:35

  11. Benni Mack commented on patch set 4 10/29/25, 14:43

    RouterConfigurator.php:3

    please use strict types for new files

    RouterConfigurator.php:22

    please make this class internal
  12. core-ci voted on patch set 4 V +1 10/29/25, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87989

  13. Benjamin Franzke uploaded patch set 5 V +1 10/30/25, 00:23

  14. Benjamin Franzke commented on patch set 5 10/30/25, 00:23

    RouterConfigurator.php:3 Reply

    Done

    RouterConfigurator.php:22 Reply

    Done
  15. core-ci voted on patch set 5 V +1 10/30/25, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88064

  16. Benni Mack voted on patch set 5 CR +1 V +1 10/30/25, 08:06

  17. Simon Schaufelberger commented on patch set 5 11/01/25, 00:31

    RouterConfigurator.php:53

    ```suggestion if ($methods !== []) { ```
  18. Benni Mack commented on patch set 6 CR +1 V +1 11/03/25, 16:47

    Published edit on patch set 5.
  19. Benni Mack commented on patch set 6 CR +1 V +1 11/03/25, 16:47

    RouterConfigurator.php:53 Reply

    Fix applied.
  20. core-ci voted on patch set 6 V +1 11/03/25, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88401

  21. Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/03/25, 17:11

  22. Benjamin Franzke voted on patch set 6 CR +2 V +2 11/03/25, 20:28

  23. Benjamin Franzke merged patch set 7 11/03/25, 20:28