Review 13.4 Merged

90806[BUGFIX] Remove double encoding of LinkBrowser label output

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 09/26/25, 11:15

Commit message

The menu tabs of the LinkBrowser emitted labels by
using `htmlspecialchars()` in the assignment of
`AbstractLinkBrowserController->loadLinkHandlers()`.

This label gets extracted by `buildMenuArray()`. This method is
called in the `mainAction` of the link browser abstract, which
assigns that array to `{menuItems}` to be used in the Fluid template
`typo3/sysext/backend/Resources/Private/Layouts/LinkBrowser.html`.
There, the usual Fluid safeguards for escaping output
are in place.

By removing the extra `htmlspecialchars` characters like
a single quote (as reported in the issue) no longer get
mangled.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 09/26/25, 08:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/26/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85583

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 09/26/25, 11:14

  4. Garvin Hicking merged patch set 2 09/26/25, 11:15