Review 13.4 Merged

90880[TASK] Use attribute selectors instead of pseudo-classes for disabled and readonly

Benjamin Kott CR +2 V +2 Normal +67 −71 updated 10/02/25, 14:50

Commit message

Replace all occurrences of :disabled and :readonly with their
corresponding attribute selectors ([disabled] and [readonly]).

Pseudo-class selectors are handled internally by browsers and cannot
be implemented in custom web components. Since the state of these
elements is always reflected in their attributes, this change has no
impact on current implementations and serves as a preparation for
future work.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 15

Review log 57

  1. Benjamin Kott commented on patch set 1 10/02/25, 13:39

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/new-record-wizard.js * typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js
  2. Benjamin Kott uploaded patch set 2 10/02/25, 13:43

  3. Benjamin Kott marked it ready for review 10/02/25, 13:43

  4. core-ci voted on patch set 2 V +1 10/02/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85922

  5. core-ci voted on patch set 1 V -1 10/02/25, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85921

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 10/02/25, 14:50

  7. Benjamin Kott merged patch set 3 10/02/25, 14:50