Review 12.4 Merged

90896[TASK] Update phpstan to 2.1.30

Garvin Hicking CR +2 V +2 Easy +13 −18 updated 10/04/25, 09:37

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.30 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Two entries are added to the baseline that will hopefully
be removed again at some point in a future PHPStan release.

The future 2.1.30 will likely notify us about that with
a nightly "phpstan max" error that removes these entries.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Garvin Hicking commented on patch set 1 10/04/25, 07:53

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. Garvin Hicking uploaded patch set 2 10/04/25, 07:58

    merge conflict
  3. Garvin Hicking marked it ready for review 10/04/25, 07:58

  4. core-ci voted on patch set 1 V -1 10/04/25, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85985

  5. core-ci voted on patch set 2 V +1 10/04/25, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85986

  6. Garvin Hicking updated the commit message in patch set 3 V +1 10/04/25, 08:30

  7. core-ci voted on patch set 3 V +1 10/04/25, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85992

  8. Stefan Bürk uploaded patch set 4 V +1 10/04/25, 08:56

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 10/04/25, 08:56

  10. core-ci voted on patch set 4 V +1 10/04/25, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86000

  11. Stefan Bürk voted on patch set 4 CR +2 V +2 10/04/25, 09:36

  12. Stefan Bürk merged patch set 5 10/04/25, 09:37