Review 13.4 Merged

91056[BUGFIX] Respect lock creation state in `backend:lock` command

Andreas Kienast CR +2 V +2 Easy +18 −12 updated 10/14/25, 09:27

Commit message

The method `LockService->lockBackend()` now passes through the return
value of `GeneralUtility::writeFile()`, allowing the `backend:lock`
command to return a proper exit code when the file creation failed.

The `BackendLocker` service class is now also marked as internal
like it was intended, to allow refactoring.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 10/14/25, 09:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/14/25, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86608

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 10/14/25, 09:26

  4. Andreas Kienast merged patch set 2 10/14/25, 09:27