Review 13.4 Merged

91074[BUGFIX] Consider starttime/endtime for versioned records

Benni Mack CR +2 V +2 Hard +318 −14 updated 10/15/25, 11:30

Commit message

The method PageRepository->checkIfPageIsHidden()
now considers if a page is visible / hidden, where
hidden also considers scheduled options (starttime/endtime)
instead of the plain "hidden" option.

This is mainly based on using "RecordAccessVoter"
instead of manual checking, allow for further
override possibilities.

Have a page in live with starttime in the future.
Go to workspace module, select that page, generate
preview links or preview side-by-side.

The main issue left is that the PreviewSimulator
does set a new VisibilityAspect now but does
not evaluate "includeScheduledRecords". We should
actually use a RecordAccessVoter->isRecordScheduled($table, $row)
method instead in the future once we have the full row.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 10

Review log 34

  1. Benni Mack commented on patch set 1 10/15/25, 10:09

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/15/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86708

  3. Benni Mack voted on patch set 1 CR +2 V +2 10/15/25, 11:30

  4. Benni Mack merged patch set 2 10/15/25, 11:30