Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

91109[WIP][BUGFIX] Make color picker keyboard accessible

Benjamin Franzke CR 0 V 0 Normal +78 −9 updated 10/30/25, 08:03

Commit message

Make the dialog interact similar to the combobox pattern,
where applicable.

TODO:

 * The code is getting messy, having to track last
   pointer/keyboard to workaround missing event source
   information in alwan sucks
   => consider upstream improvements
 * The entire code would improve
 * Aria
   * aria-controls and aria-expanded for the input
   * role=dialog for the popover element

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/91109/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/91109/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 91109 [WIP][BUGFIX] Make color picker keyboard accessible This change

  2. main 90936[BUGFIX] Show semantic labels in color picker and merge value picker This change is based on it Merged Benjamin Franzke CR +2 V +2 → 13.4 Normal +56 −48

    The chain has patch set 5 of 7, the changes above it need a rebase.

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 10/16/25, 22:06

  2. core-ci voted on patch set 1 V +1 10/16/25, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86848

  3. Benjamin Franzke marked it work in progress 10/30/25, 08:03