Review main Merged Breaking

91208[!!!][TASK] TCA: Consolidate palette labels in core.form.palettes

Benni Mack CR +2 V +2 Hard +350 −113 updated 10/27/25, 17:24

Commit message

This change consolidates commonly used palette labels from various
extensions are added into the central palettes.xlf file,
allowing for consistent palette naming across the TYPO3 Core.

All old labels have been marked with x-unused-since="14.0" to
indicate they can be removed in a future version.

Note:
- We're doing all of these TCA changes step by step to see
if we can consolidate or rename files or labels or "keys".
This means, I am also evaluating these labels one by one.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 20

Review log 2023

  1. Benni Mack uploaded patch set 1 10/22/25, 15:35

  2. core-ci voted on patch set 1 V +1 10/22/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87275

  3. Lina Wolf commented on patch set 1 10/22/25, 18:49

    be_groups.php:309

    I would suggest that we preserve the lowerCamelCase here as that makes the labels easier to read and is the offical suggestion in the docs: [lowerCamelCase ](https://docs.typo3.org/permalink/t3coreapi:xliff-id-naming-lower-camel)

    pages.php:845

    I would suggest to remove the label in total. We have the tab called "General" and then the palette called "General" it is just repetition of an empty word providing no additonal information

    locallang_palettes.xlf:84

    ID and content seem to have no relation?

    locallang_palettes.xlf:118

    ```suggestion <source>General SEO Settings</source> ``` Lets stick to the same case all over: All title case or all sentence case
  4. Lina Wolf commented on patch set 1 10/22/25, 18:52

    locallang_palettes.xlf:16

    ```suggestion <source>Language Permissions</source> ```

    locallang_palettes.xlf:19

    ```suggestion <source>General Permissions</source> ```

    locallang_palettes.xlf:22

    ```suggestion <source>Specific Permissions</source> ```

    locallang_palettes.xlf:91

    ```suggestion <source>File Links Layout</source> ```

    locallang_palettes.xlf:109

    ```suggestion <source>Geolocation</source> ``` Geolocation is one word, even in English: https://en.wikipedia.org/wiki/W3C_Geolocation_API

    locallang_palettes.xlf:121

    ```suggestion <source>Robot Instructions</source> ```

    locallang_palettes.xlf:136

    ```suggestion <source>Additional Configuration</source> ```
  5. Lina Wolf commented on patch set 1 10/22/25, 19:04

    pages.php:884

    Label is just a repetiion of the only field: would remove it

    pages.php:888

    Label ist just a repetion of the filed name

    pages.php:908

    "Replace Content" does not really add value, maybe even more confusion

    pages.php:932

    We are in Tab Ressources then pallette files, then field media, it is much repetition without added value, would remove

    pages.php:39

    I would remove this label: We are in tab SEO, then we repeat "General SEO settings" there is no added value

    pages.php:47

    I would remove this label, it is a repetition of the field label and provides no attional information
  6. Benni Mack commented on patch set 1 10/23/25, 11:31

    be_groups.php:309 Reply

    Yes. I should adapt them. I suggest to use snake_case for future / new labels as best practice / recommendation. This reflects the implementation of a) database tables + fields ("tx_blog_domain_model_news.short_description") b) translation domains, which contain the extension key ("bootstrap_package.db" as domain name)

    sys_reaction_create_record.php:70

    this does not work, need to adapt this

    sys_webhook.php:41

    does not work, need to rework this

    sys_workspace.php:248

    I need to adapt this
  7. Lina Wolf commented on patch set 1 10/23/25, 11:47

    be_groups.php:309 Reply

    yes, I like that. We should change it in the docs then. Do you want me to transfer all labels that are two words into snake case?
  8. Benni Mack commented on patch set 1 10/23/25, 11:48

    be_groups.php:309 Reply

    it's not worth it for existing labels, but I'm already half through doing the adaptions for this change (as I found more issues with this change) - will push a new version ASAP.
  9. Lina Wolf commented on patch set 1 10/23/25, 11:50

    be_groups.php:309 Reply

    the labels in this change are new though and they mostly had camel case before, just removing the camel case makes them harder to read
  10. Benni Mack uploaded patch set 2 V +1 10/23/25, 13:47

  11. core-ci voted on patch set 2 V +1 10/23/25, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87425

  12. Lina Wolf commented on patch set 2 10/23/25, 14:20

    locallang_palettes.xlf:16 Reply

    Done

    locallang_palettes.xlf:19 Reply

    Done

    locallang_palettes.xlf:22 Reply

    Done

    locallang_palettes.xlf:91 Reply

    Done

    locallang_palettes.xlf:118 Reply

    Done

    locallang_palettes.xlf:121 Reply

    Done

    locallang_palettes.xlf:136 Reply

    Done
  13. Oli Bartsch uploaded patch set 3 V +1 10/24/25, 14:40

  14. Oli Bartsch commented on patch set 2 CR +1 V +1 10/24/25, 14:40

    sys_reaction_create_record.php:70 Reply

    Done
  15. core-ci voted on patch set 3 V +1 10/24/25, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87514

  16. Lina Wolf commented on patch set 3 10/27/25, 13:39

    be_groups.php:309 Reply

    Done
  17. Lina Wolf commented on patch set 3 10/27/25, 14:48

    pages.php:845 Reply

    Acknowledged

    pages.php:884 Reply

    Acknowledged

    pages.php:888 Reply

    Acknowledged

    pages.php:908 Reply

    Acknowledged

    pages.php:932 Reply

    Acknowledged

    locallang_palettes.xlf:84 Reply

    Acknowledged

    locallang_palettes.xlf:109 Reply

    Acknowledged

    pages.php:39 Reply

    Acknowledged

    pages.php:47 Reply

    Acknowledged
  18. Lina Wolf commented on patch set 3 10/27/25, 15:02

    sys_webhook.php:41 Reply

    Done

    sys_workspace.php:248 Reply

    Done
  19. Lina Wolf voted on patch set 3 CR +1 V +1 10/27/25, 15:02

  20. Oli Bartsch voted on patch set 3 CR +1 V +1 10/27/25, 16:54

  21. Benni Mack voted on patch set 3 CR +2 V +2 10/27/25, 17:24

  22. Benni Mack merged patch set 4 10/27/25, 17:24

  23. Benni Mack commented on patch set 4 10/27/25, 17:24

    thank you!