Review 13.4 Merged

91216[BUGFIX] Apply error class to Advanced Password fields

Garvin Hicking CR +2 V +2 Easy +2 −4 updated 10/23/25, 09:11

Commit message

The error class is placed on the fields based on the validation results.
The validation error is attached to the parent property,
not to the individual fields "password" and "confirmation".

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Garvin Hicking commented on patch set 1 10/23/25, 08:29

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Resources/Private/Frontend/Partials/AdvancedPassword.html
  2. Garvin Hicking marked it ready for review 10/23/25, 08:36

  3. core-ci voted on patch set 1 V +1 10/23/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87384

  4. Garvin Hicking commented on patch set 1 10/23/25, 08:36

    Backport note: The fix only applies to v2 of the frontend (only there the 'validation context' is available)
  5. Garvin Hicking uploaded patch set 2 V +1 10/23/25, 08:39

  6. core-ci voted on patch set 2 V +1 10/23/25, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87386

  7. Josua Vogel voted on patch set 2 CR +1 V +1 10/23/25, 08:48

  8. Garvin Hicking voted on patch set 2 CR +2 V +2 10/23/25, 09:11

  9. Garvin Hicking merged patch set 3 10/23/25, 09:11