Review 13.4 Merged

91217[BUGFIX] Avoid ORDER BY from count queries in Webhooks/Reactions

Oli Bartsch CR +2 V +2 Easy +22 −18 updated 10/23/25, 09:03

Commit message

PostgreSQL is stricter than MySQL when it comes
to `GROUP BY` clauses and `ORDER BY` in count
queries. When using `count(*)` with `ORDER BY`
on a column that's not in the `GROUP BY` clause,
PostgreSQL throws an error.

The `ORDER BY` clause is unnecessary for count
queries and can cause compatibility issues with
PostgreSQL. This change adds an optional parameter
to skip `ORDER BY` when counting records.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 10/23/25, 08:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/23/25, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87385

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/23/25, 09:03

  4. Oli Bartsch merged patch set 2 10/23/25, 09:03