Review main Merged

91296[FEATURE] Add Bookmarks dashboard widget

Michael Binder CR +2 V +2 Hard +288 −0 updated 11/24/25, 18:56

Commit message

This patch adds a new dashboard widget, which allows editors to display
their saved bookmarks.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Sven Liebert +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Sven Liebert +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2536

Show 711 earlier messages
  1. Michael Binder uploaded patch set 1 10/27/25, 21:00

  2. core-ci voted on patch set 1 V -1 10/27/25, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87745

  3. Michael Binder commented on patch set 2 V -1 10/28/25, 09:13

    Cherry Picked from branch main.
  4. Michael Binder uploaded patch set 3 10/28/25, 09:24

  5. core-ci voted on patch set 2 V -1 10/28/25, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87775

  6. Michael Binder uploaded patch set 4 10/28/25, 09:31

  7. core-ci voted on patch set 3 V -1 10/28/25, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87781

  8. core-ci voted on patch set 4 V +1 10/28/25, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87782

  9. Oli Bartsch commented on patch set 4 10/28/25, 11:36

    Feature-107873-NewBookmarksWidget.rst:19

    The contents of this sections are more like "key benefits" and should be moved under the "Description" section. In "Impact" we usually make a short summary of the improvement as one or two sentence(s).

    BookmarksWidget.php:24

    Could we please add a "limit" option to this element? - See e.g. the rss widget for an example.
  10. Fabien Udriot commented on patch set 4 V +1 10/28/25, 13:02

    Tested successfully
  11. Michael Binder uploaded patch set 5 V +1 10/29/25, 13:15

  1. Michael Binder uploaded patch set 6 10/29/25, 13:21

  2. core-ci voted on patch set 5 V -1 10/29/25, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87968

  3. core-ci voted on patch set 6 V -1 10/29/25, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87971

  4. Michael Binder uploaded patch set 7 V -1 10/29/25, 14:19

  5. core-ci voted on patch set 7 V +1 10/29/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87985

  6. Michael Binder commented on patch set 7 10/29/25, 14:34

    Feature-107873-NewBookmarksWidget.rst:19 Reply

    I have moved the Impact points and added information about the setting options.

    BookmarksWidget.php:24 Reply

    It is now possible for the user to select the limit, add a different label and choose a bookmark group. If all bookmarks are to be displayed, the limit applies across the various groups and displays the corresponding bookmarks.
  7. Michael Binder commented on patch set 7 10/29/25, 16:34

    Feature-107873-NewBookmarksWidget.rst:19 Reply

    Done

    BookmarksWidget.php:24 Reply

    Done
  8. Oli Bartsch uploaded patch set 8 V +1 11/21/25, 19:44

  9. Oli Bartsch voted on patch set 8 CR +1 V +1 11/21/25, 19:47

  10. core-ci voted on patch set 8 V +1 11/21/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90560

  11. Simon Schaufelberger commented on patch set 8 11/22/25, 07:18

    BookmarksWidget.php:91

    Since the class is final and this method doesn't extend an existing class, it can be private. Also check the others below.
  12. Stefan Bürk uploaded patch set 9 CR +1 V +1 11/24/25, 18:34

  13. Stefan Bürk uploaded patch set 10 11/24/25, 18:35

  14. Stefan Bürk commented on patch set 10 CR +1 V +1 11/24/25, 18:35

    BookmarksWidget.php:91 Reply

    Done
  15. Simon Schaufelberger uploaded patch set 11 CR +1 V +1 11/24/25, 18:46

  16. core-ci voted on patch set 9 V +1 11/24/25, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90884

  17. core-ci voted on patch set 10 V +1 11/24/25, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90885

  18. Simon Schaufelberger voted on patch set 11 CR +1 V +1 11/24/25, 18:47

  19. Stefan Bürk voted on patch set 11 CR +1 V +1 11/24/25, 18:48

  20. Sven Liebert commented on patch set 11 11/24/25, 18:51

    Bookmarks to translated pages are not shown. Is that wanted behaviour?
  21. Sven Liebert commented on patch set 11 11/24/25, 18:53

    Reply

    Sorry. Bullshit. Ran into maximum bookmarks limit without notice it :D
  22. core-ci voted on patch set 11 V +1 11/24/25, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90887

  23. Sven Liebert voted on patch set 11 CR +1 V +1 11/24/25, 18:55

  24. Stefan Bürk voted on patch set 11 CR +2 V +2 11/24/25, 18:55

  25. Stefan Bürk merged patch set 12 11/24/25, 18:56