Review main Merged

91299[BUGFIX] Prevent topbar button name duplication in firefox a11y tree

Benjamin Franzke CR +2 V +2 Easy +4 −5 updated 07/16/26, 12:29

Commit message

Firefox collects title attributes of DOM elements as
accessible names, even if their content is empty (or marked as
aria-hidden).

Since toolbar items contain icon wrapper markup that contains a title,
(which is needed for desktop mouse users, since the sibling text title
is visually hidden) and a title node as a text leaf, the title was read
out twice by screenreaders in firefox, since it's accessibility tree
collected the icon wrapper with the title as one generic node
and the text leaf as another node.

To unify browser behavior we're adding an explicit aria-hidden
attribute to the icon wrapper, in order for firefox to
interpret this DOM tree as other browser vendors do.

In addition the title attribute is removed from the search and single
clear-cache toolbar buttons in order to unify their behavior with the
other toolbar buttons which do only contain a title attribute on
the icon wrapper.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Michael Telgkamp +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Michael Telgkamp +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1419

  1. Benjamin Franzke uploaded patch set 1 10/28/25, 07:31

  2. Benjamin Franzke wrote 10/28/25, 07:31

    Hashtag added: tas2025
  3. core-ci voted on patch set 1 V +1 10/28/25, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87764

  4. Michael Telgkamp commented on patch set 1 11/05/25, 15:12

    I would prefer to have the title attribute on the interactive element (the button), as this is where the information belongs to. Currently, when hovering the button on parts that are not covered by the icon, no tooltip is shown. This solution will also become problematic when a tooltip with the title information should be shown when focusing the button with the keyboard. I see a problem with the "System Information" button, where the title differs from the "accessible name" received from the content, as the latter might include the number of errors found (System information 1).
  5. Benjamin Franzke commented on patch set 1 11/13/25, 14:43

    Reply

    > I would prefer to have the title attribute on the interactive element (the button) I agree, but that requires a larger refactoring towards the mobile rendering, since the button labels are *shown* in that case. This would result in titles that *exactly* match the button label, which then contain 0 information, and are therefore to be avoided. So, I hope it's ok for you that we address the screenreader issue "only", while preserving the semi-perfect state for mouse users. > I see a problem with the "System Information" button, where the title differs from the "accessible name" received from the content, as the latter might include the number of errors found (System information 1). Also ack here, we should add a labels to explicitly separate the indicator count from the name. I would also do that in a different patch.
  6. Christian Kuhn voted on patch set 1 CR +1 V +1 11/13/25, 15:36

  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 06:38

  8. core-ci voted on patch set 2 V -1 04/22/26, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100750

  9. Christian Kuhn wrote 06/18/26, 23:09

    Removed reviewer Christian Kuhn.
  10. Andreas Kienast uploaded patch set 3 V -1 06/26/26, 09:26

  11. Andreas Kienast uploaded patch set 4 06/26/26, 09:28

  12. core-ci voted on patch set 3 V -1 06/26/26, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103931

  13. core-ci voted on patch set 4 V -1 06/26/26, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103932

  14. Michael Telgkamp commented on patch set 4 CR +1 V +1 06/26/26, 15:52

    Despite the CI script having problems uploading the artifacts, I give my +1 votes for this
  15. core-ci voted on patch set 4 V +1 06/29/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103932

  16. Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/29/26, 13:23

  17. Benni Mack voted on patch set 4 CR +2 V +2 07/15/26, 13:15

  18. Benjamin Franzke commented on patch set 4 CR +2 V +2 07/16/26, 12:29

    Confirmed on Firefox 152 again, "Clear cache Clear cache" becomes "Clear cache" and "Search Search" is now "Search" as expected.
  19. Benjamin Franzke merged patch set 5 07/16/26, 12:29