91299[BUGFIX] Prevent topbar button name duplication in firefox a11y tree
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +2
- Michael Telgkamp +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +2
- Michael Telgkamp +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Resources/Private/Partials/ToolbarItems/ToolbarItem.fluid.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/BookmarkToolbarItemItem.fluid.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/ClearCacheToolbarItemSingle.fluid.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.fluid.html+0 −1
- typo3/sysext/opendocs/Resources/Private/Templates/ToolbarItems/ToolbarItem.fluid.html+1 −1
Review log 1419
-
Benjamin Franzke uploaded patch set 1 10/28/25, 07:31
-
Benjamin Franzke wrote 10/28/25, 07:31
Hashtag added: tas2025 -
core-ci voted on patch set 1 V +1 10/28/25, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87764
-
Michael Telgkamp commented on patch set 1 11/05/25, 15:12
I would prefer to have the title attribute on the interactive element (the button), as this is where the information belongs to. Currently, when hovering the button on parts that are not covered by the icon, no tooltip is shown. This solution will also become problematic when a tooltip with the title information should be shown when focusing the button with the keyboard. I see a problem with the "System Information" button, where the title differs from the "accessible name" received from the content, as the latter might include the number of errors found (System information 1). -
Benjamin Franzke commented on patch set 1 11/13/25, 14:43
Reply
> I would prefer to have the title attribute on the interactive element (the button) I agree, but that requires a larger refactoring towards the mobile rendering, since the button labels are *shown* in that case. This would result in titles that *exactly* match the button label, which then contain 0 information, and are therefore to be avoided. So, I hope it's ok for you that we address the screenreader issue "only", while preserving the semi-perfect state for mouse users. > I see a problem with the "System Information" button, where the title differs from the "accessible name" received from the content, as the latter might include the number of errors found (System information 1). Also ack here, we should add a labels to explicitly separate the indicator count from the name. I would also do that in a different patch. -
Christian Kuhn voted on patch set 1 CR +1 V +1 11/13/25, 15:36
-
Benni Mack updated the commit message in patch set 2
CR +1V +104/22/26, 06:38 -
core-ci voted on patch set 2 V -1 04/22/26, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100750
-
Christian Kuhn wrote 06/18/26, 23:09
Removed reviewer Christian Kuhn. -
Andreas Kienast uploaded patch set 3
V -106/26/26, 09:26 -
Andreas Kienast uploaded patch set 4 06/26/26, 09:28
-
core-ci voted on patch set 3 V -1 06/26/26, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103931
-
core-ci voted on patch set 4 V -1 06/26/26, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103932
-
Michael Telgkamp commented on patch set 4 CR +1 V +1 06/26/26, 15:52
Despite the CI script having problems uploading the artifacts, I give my +1 votes for this -
core-ci voted on patch set 4 V +1 06/29/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103932
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 06/29/26, 13:23
-
Benni Mack voted on patch set 4 CR +2 V +2 07/15/26, 13:15
-
Benjamin Franzke commented on patch set 4 CR +2 V +2 07/16/26, 12:29
Confirmed on Firefox 152 again, "Clear cache Clear cache" becomes "Clear cache" and "Search Search" is now "Search" as expected. -
Benjamin Franzke merged patch set 5 07/16/26, 12:29