Review main Merged

91330[BUGFIX] Fix broken CSS and JS resource loading in dashboard

Benjamin Franzke CR +2 V +2 Easy +0 −7 updated 10/29/25, 13:43

Commit message

Dashboard broke with the integration of the new system resource api
in #107537 due to public resource paths being tried to be resolved
twice, once in `DashboardInitializationService` and a second time
implicitly in `PageRenderer`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Benjamin Franzke uploaded patch set 1 10/29/25, 12:18

  2. Helmut Hummel commented on patch set 1 CR +1 V +1 10/29/25, 12:30

    Thanks. Did not catch this before, but I find it pretty cool, that the introduction of more strict distinction of resource identifiers and URLs uncovered this unnecessary URL generation here. I love it when a fix is to remove code
  3. core-ci voted on patch set 1 V +1 10/29/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87958

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 10/29/25, 12:40

  5. Georg Ringer voted on patch set 1 CR +1 V +1 10/29/25, 12:41

  6. Benjamin Franzke voted on patch set 1 CR +2 V +2 10/29/25, 13:43

  7. Benjamin Franzke merged patch set 2 10/29/25, 13:43