Review main Merged Breaking

91350[!!!][FEATURE] Implement relative URIs as system resources

Helmut Hummel CR +2 V +2 Hard +525 −156 updated 11/15/25, 09:13

Commit message

When working on #107537, the "external" property for asset inclusion
in TypoScript was accidentally omitted. When researching what "external"
exactly means and how it is documented, some contradicting information
was found, leading to confusion what actually is correct (#105592).

When looking at the top level use case, the "external" option
was used to allow URIs to be used as defined and to be rendered
to HTML, without TYPO3 having to resolve any other resource from that.

This change add the possibility to define relative URIs as system resource
by prefixing the URI with the "URI:" keyword.

With this new syntax addition in place, denoting an URIs to be "external"
would be redundant and is therefore removed.

The benefit of this new syntax is, that it can be used anywhere where
system resources are evaluated to produce URIs.

So for example URI resource can now be used in <f:asset.css> view helper,
whereas the recently added feature #102255 only added this
possibility to the PHP API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 23

Show 3 more files

Review log 2538

Show 813 earlier messages
  1. Helmut Hummel uploaded patch set 1 10/29/25, 20:46

  2. Helmut Hummel uploaded patch set 2 10/29/25, 20:46

  3. core-ci voted on patch set 1 V -1 10/29/25, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88047

  4. core-ci voted on patch set 2 V -1 10/29/25, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88048

  5. Georg Ringer commented on patch set 2 10/30/25, 07:08

  6. Josef Glatz updated the commit message in patch set 3 V -1 10/30/25, 07:38

  7. Josef Glatz commented on patch set 3 10/30/25, 07:39

    I've abandoned my patch in flavour of Helmut's patch
  8. Josef Glatz updated the commit message in patch set 4 10/30/25, 07:39

  9. Helmut Hummel uploaded patch set 5 10/30/25, 07:43

  10. core-ci voted on patch set 3 V -1 10/30/25, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88081

  11. core-ci voted on patch set 4 V -1 10/30/25, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88082

  12. core-ci voted on patch set 5 V -1 10/30/25, 07:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88083

  13. Helmut Hummel uploaded patch set 6 V -1 10/30/25, 09:13

  1. Helmut Hummel updated the commit message in patch set 7 10/30/25, 09:23

  2. core-ci voted on patch set 6 V +1 10/30/25, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88093

  3. core-ci voted on patch set 7 V +1 10/30/25, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88095

  4. Helmut Hummel rebased onto patch set 8 V +1 11/10/25, 09:49

  5. core-ci voted on patch set 8 V +1 11/10/25, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88814

  6. Oliver Klee voted on patch set 8 V +1 11/10/25, 10:04

  7. Helmut Hummel uploaded patch set 9 V +1 11/10/25, 13:24

  8. core-ci voted on patch set 9 V +1 11/10/25, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88849

  9. Oliver Klee voted on patch set 9 V +1 11/10/25, 15:11

  10. Helmut Hummel uploaded patch set 10 V +1 11/13/25, 12:35

  11. core-ci voted on patch set 10 V +1 11/13/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89492

  12. Helmut Hummel uploaded patch set 11 V +1 11/14/25, 11:29

  13. core-ci voted on patch set 11 V -1 11/14/25, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89679

  14. Helmut Hummel uploaded patch set 12 V -1 11/14/25, 12:22

  15. Helmut Hummel commented on patch set 11 11/14/25, 12:23

    Reply

    no, it does not. it is related though. The question is how we want the behaviour to be exactly. My proposal is to kind of do the opposite. So it solves it, by rejecting it and adding a different approach
  16. core-ci voted on patch set 12 V +1 11/14/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89685

  17. Christian Kuhn voted on patch set 12 CR +1 V +1 11/14/25, 18:33

  18. Christian Kuhn commented on patch set 12 V 0 CR -1 11/14/25, 19:05

    will rebase.
  19. Christian Kuhn uploaded patch set 13 CR -1 V +1 11/14/25, 19:10

  20. core-ci voted on patch set 13 V +1 11/14/25, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89715

  21. Christian Kuhn voted on patch set 13 CR +1 V +1 11/14/25, 19:19

  22. Benni Mack voted on patch set 13 CR +2 V +2 11/14/25, 19:27

  23. Benni Mack merged patch set 14 11/14/25, 19:27

  24. Simon Schaufelberger commented on patch set 14 11/14/25, 22:52

    Breaking-107927-ExternalAttributesRemoved.rst:53

    @benni@typo3.org the indentation is not correct here. Worth to fix it?
  25. Helmut Hummel commented on patch set 14 11/15/25, 09:13

    Breaking-107927-ExternalAttributesRemoved.rst:53 Reply

    @simonschaufi+typo3@gmail.com fixed here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91673