Review 13.4 Merged

91351[BUGFIX] Streamline pseudo button behavior

Benjamin Franzke CR +2 V +2 Hard +122 −289 updated 11/10/25, 08:33

Commit message

Ensure that SPACE activates on keyup, and ENTER
on keydown, as every browser vendor/OS does for
native buttons.

Also make sure to share code to avoid discrepancies
and to ease maintenance.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 69

  1. Benjamin Franzke uploaded patch set 1 10/29/25, 22:00

  2. core-ci voted on patch set 1 V +1 10/29/25, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88060

  3. Benjamin Kott commented on patch set 2 V +1 11/10/25, 08:20

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/scheduler/new-scheduler-task-wizard-button.ts * Build/Sources/TypeScript/scheduler/setup-check-button.ts * typo3/sysext/backend/Resources/Public/JavaScript/record-download-button.js * typo3/sysext/scheduler/Resources/Public/JavaScript/new-scheduler-task-wizard-button.js * typo3/sysext/scheduler/Resources/Public/JavaScript/setup-check-button.js
  4. Benjamin Kott uploaded patch set 3 11/10/25, 08:25

  5. Benjamin Kott commented on patch set 3 11/10/25, 08:25

    This change is ready for review.
  6. core-ci voted on patch set 3 V +1 11/10/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88805

  7. core-ci voted on patch set 2 V -1 11/10/25, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88804

  8. Benjamin Kott voted on patch set 3 CR +2 V +2 11/10/25, 08:33

  9. Benjamin Kott merged patch set 4 11/10/25, 08:33