Review main Merged

91366[TASK] Cover FAL public URLs of non-public storages in tests

Fabien Udriot CR +2 V +2 Easy +36 −0 updated 09/25/26, 06:58

Commit message

Fetching the public URL of a file in a non-public storage without
a request used to return a malformed dumpFile URL. Since the request
dependency was made explicit, getPublicUrl() returns null in that
case and an absolute dumpFile URL when a request with the
"normalizedParams" and "applicationType" attributes is available.

Add functional tests that pin down both behaviours, so CLI code
can rely on them.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Fabien Udriot uploaded patch set 1 10/30/25, 13:24

  2. Fabien Udriot uploaded patch set 2 10/30/25, 13:26

  3. core-ci voted on patch set 1 V -1 10/30/25, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88143

  4. core-ci voted on patch set 2 V -1 10/30/25, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88144

  5. Fabien Udriot marked it work in progress 10/30/25, 14:17

  6. Fabien Udriot uploaded patch set 3 V -1 10/30/25, 15:23

  7. core-ci voted on patch set 3 V -1 10/30/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88160

  8. Benni Mack uploaded patch set 4 V -1 09/25/26, 01:31

  9. Benni Mack marked it ready for review 09/25/26, 01:33

  10. Benni Mack voted on patch set 4 CR +1 V +1 09/25/26, 01:33

  11. core-ci voted on patch set 4 V +1 09/25/26, 01:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109197

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 09/25/26, 06:58

  13. Stefan Bürk merged patch set 5 09/25/26, 06:58