Issue Bug Resolved

#90330Wrong publicUrl for FAL files in non-public storages generated from CLI

Stephan Großberndt 02/05/20, 14:58 updated 09/25/26, 07:00

Description

In at least TYPO3 9.5.13 fetching the public url of a FAL \TYPO3\CMS\Core\Resource\File located in a non-public storage using $file->getPublicUrl() from the commandline in a Symfony command returns

http:///var/www/example.org/www/typo3/sysext/core/bin/index.php?eID=dumpFile&t=f&f=[fileUid]&token=[token]

Using $file->getPublicUrl(TRUE) returns

../../../../http://var/www/example.org/www/typo3/sysext/core/bin/index.php?eID=dumpFile&t=f&f=[fileUid]&token=[token]

Last changes to that area were done in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/57240/11/typo3/sysext/core/Classes/Resource/ResourceStorage.php#1304
https://review.typo3.org/c/Packages/TYPO3.CMS/+/53140/8/typo3/sysext/core/Classes/Resource/ResourceStorage.php#1297
https://review.typo3.org/c/Packages/TYPO3.CMS/+/53789/5/typo3/sysext/core/Classes/Resource/ResourceStorage.php#1304

This should be a valid URL not mangling local file paths with eID-GET-Parameters.

For TYPO3 9+ it probably should take site configuration in account, otherwise it would even help if at least just the relative path

/index.php?eID=dumpFile&t=f&f=[fileUid]&token=[token]

would be returned

Reviews 1

History 913

  1. Stephan Großberndt commented <span data-processor="relativetime" data-value="2020-02-05T17:13:32+00:00" > 02/05/20, 17:13 </span>

    My current workaround:

        /**
         * Cached public URL
         *
         * @var string
         */
        private $publicSiteUrl = '';
    
        /**
         * Cached wrong local path from File::getPublicUrl()
         *
         * @var string
         * @link https://forge.typo3.org/issues/90330
         */
        private $publicUrlLocalPath = '';
    
        /**
         * Workaround for "Wrong publicUrl for FAL files in non-public storages generated from CLI"
         *
         * @param File $file
         * @return string
         * @throws SiteNotFoundException
         * @link https://forge.typo3.org/issues/90330
         */
        protected function getPublicUrl(File $file): string {
    
            if (empty($this->publicUrlLocalPath)) {
                $this->publicUrlLocalPath = 'http://' . Environment::getPublicPath() . '/typo3/sysext/core/bin/';
            }
            if (empty($this->publicSiteUrl)) {
                $siteFinder = GeneralUtility::makeInstance(SiteFinder::class);
                $this->publicSiteUrl = $siteFinder->getSiteByIdentifier('identifier-of-my-site')->getBase();
            }
    
            $publicUrl = $file->getPublicUrl();
            if (substr($publicUrl, 0, 8) === 'http:///') {
                $publicUrl = str_replace($this->publicUrlLocalPath, $this->publicSiteUrl, $publicUrl);
            }
    
            return $publicUrl;
        }
  2. Stephan Großberndt commented <span data-processor="relativetime" data-value="2023-06-14T15:47:04+00:00" > 06/14/23, 15:47 </span>

    This issue is still present in TYPO3 v12, here $file->getPublicUrl() and $file->getPublicUrl(TRUE) both return

    http://bin/index.php?eID=dumpFile&t=f&f=2096&token=bd6e0cc99d3c2a7a6745416bff82d61ce87d44dd
  3. Gerrit Code Review pushed patch set 1 for main to change 91366 status Accepted Under Review <span data-processor="relativetime" data-value="2025-10-30T13:24:37+00:00" > 10/30/25, 13:24 </span>

  4. Benni Mack commented <span data-processor="relativetime" data-value="2026-09-25T01:33:11+00:00" > 09/25/26, 01:33 </span>

    This was fixed with #109548 but we add tests now

  5. Anonymous commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-09-25T07:00:10+00:00" > 09/25/26, 07:00 </span>

    Applied in changeset commit:ceebf222c966ce8290de1e022b4b9264a2bdc324.