Review 12.4 Merged

91429[BUGFIX] Avoid performance bottleneck in system information toolbar

Garvin Hicking CR +2 V +2 Easy +16 −6 updated 11/05/25, 17:20

Commit message

The system information toolbar renders the entire backend in the toolbar
dropdown, if logged out in another tab, because the request to the
information refresh route is redirected to the login page (and once
logged back in, to the main backend controller).

Once the main backend controller is inserted (e.g. after relogin in
another tab), a nested system information toolbar will be updated
to contain the backend again and again and again, resulting in
exponential growth, which can lead to 10GB of RAM usage and
4 million DOM nodes over time, making the entire backend unresponsive.

To circumvent this issue, we're now instruction `fetch()` to avoid
following redirects, which means we can detect that a redirect
would have performed and ignore the request result instead of
inserting invalid markup.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Garvin Hicking commented on patch set 1 11/05/25, 15:56

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/toolbar/system-information-menu.ts * typo3/sysext/backend/Resources/Public/JavaScript/toolbar/system-information-menu.js
  2. Garvin Hicking uploaded patch set 2 11/05/25, 15:59

    address merge conflict
  3. core-ci voted on patch set 1 V -1 11/05/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88529

  4. core-ci voted on patch set 2 V +1 11/05/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88530

  5. Benjamin Franzke commented on patch set 2 CR +1 V +1 11/05/25, 16:44

    This change is ready for review.
    Thanks, I had the same change (just differed) prepared and tested locally, but forgot to push 😂 Can be merged!
  6. Garvin Hicking commented on patch set 2 CR +2 V +2 11/05/25, 17:20

    Thanks for fixing this longstanding issue which always made me close all TYPO3 backend tabs for my browser that usually runs 30 days without a restargh 😅
  7. Garvin Hicking merged patch set 3 11/05/25, 17:20