Review main Ready for review Quiet

91453[TASK] Extend breadcrumb context to sites

Elias Häußler CR 0 V 0 Hard +312 −111 updated 10/16/26, 13:32

Commit message

A dedicated SiteBreadcrumbProvider renders a breadcrumb for a site
context, set via DocHeaderComponent::setSiteBreadcrumb().

The site is represented by its root page, labelled with the site
identifier when the root page is missing. When further nodes follow,
the site node links to the site detail view - the entry point for a
single site - for users with access to the site configuration module.
Module nodes always link to the module entry point, as the routes of
a site view can not be entered without the site identifier.

The site configuration detail and edit views and the site settings
view now use the site context instead of assembling these nodes by
hand.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 9
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/53/91453/9 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/53/91453/9 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 6

Issues 3

Files 7

Review log 1726

Show 1 earlier messages
  1. Elias Häußler uploaded patch set 1 11/08/25, 22:21

  1. Elias Häußler uploaded patch set 2 11/08/25, 22:21

  2. Elias Häußler marked it work in progress 11/08/25, 22:22

  3. Elias Häußler uploaded patch set 3 11/08/25, 22:24

  4. Elias Häußler commented on patch set 3 11/08/25, 22:26

    @benjamin.kott@outlook.com @benni@typo3.org @bo@cedev.de What do you think about this improvement for the breadcrumb component? At the moment, the breadcrumb component is not implemented for the site configuration module.
  5. core-ci voted on patch set 1 V -1 11/08/25, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88717

  6. core-ci voted on patch set 2 V +1 11/08/25, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88718

  7. core-ci voted on patch set 3 V +1 11/08/25, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88719

  8. Elias Häußler uploaded patch set 4 V +1 11/12/25, 09:05

  9. Elias Häußler marked it ready for review 11/12/25, 09:05

  10. core-ci voted on patch set 4 V +1 11/12/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89171

  11. Oli Bartsch commented on patch set 4 V -1 11/12/25, 11:00

    Unresolved

    I need to fix preserving of module actions first.
  12. Elias Häußler rebased onto patch set 5 V +1 11/13/25, 20:10

  13. core-ci voted on patch set 5 V -1 11/13/25, 20:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89583

  14. Elias Häußler uploaded patch set 6 V -1 11/13/25, 20:34

  15. core-ci voted on patch set 6 V +1 11/13/25, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89586

  16. Oli Bartsch commented on patch set 6 11/13/25, 21:12

    BreadcrumbFactory.php:210

    site
  17. Elias Häußler uploaded patch set 7 V +1 11/13/25, 21:35

  18. Elias Häußler commented on patch set 7 11/13/25, 21:35

    BreadcrumbFactory.php:210 Reply

    Done
  19. core-ci voted on patch set 7 V +1 11/13/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89598

  20. Elias Häußler uploaded patch set 8 V +1 11/20/25, 14:28

  21. core-ci voted on patch set 8 V +1 11/20/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90295

  22. Georg Ringer voted on patch set 8 CR +1 V +1 11/20/25, 19:56

  23. Benni Mack wrote 04/21/26, 14:53

    Removed cc Benni Mack.
  24. Benni Mack uploaded patch set 9 CR +1 V +1 10/16/26, 13:25

  25. core-ci voted on patch set 9 V +1 10/16/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111361