91453[TASK] Extend breadcrumb context to sites
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/53/91453/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/53/91453/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 6
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
- main 94780[TASK] Deprecate Site setting typo3Language
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 90644[POC][FEATURE] Introduce attribute-based backend module registration
Issues 3
Files 7
- typo3/sysext/backend/Classes/Breadcrumb/BreadcrumbContext.php+4 −3
- typo3/sysext/backend/Classes/Breadcrumb/BreadcrumbFactory.php2+12 −0
- typo3/sysext/backend/Classes/Breadcrumb/SiteBreadcrumbProvider.phpnew+162 −0
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+19 −24
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+6 −17
- typo3/sysext/backend/Classes/Template/Components/DocHeaderComponent.php+14 −0
- typo3/sysext/backend/Tests/Functional/Controller/SiteBreadcrumbTest.php+95 −67
Review log 1726
Show 1 earlier messages
-
Elias Häußler uploaded patch set 1 11/08/25, 22:21
-
Elias Häußler uploaded patch set 2 11/08/25, 22:21
-
Elias Häußler marked it work in progress 11/08/25, 22:22
-
Elias Häußler uploaded patch set 3 11/08/25, 22:24
-
Elias Häußler commented on patch set 3 11/08/25, 22:26
@benjamin.kott@outlook.com @benni@typo3.org @bo@cedev.de What do you think about this improvement for the breadcrumb component? At the moment, the breadcrumb component is not implemented for the site configuration module. -
core-ci voted on patch set 1 V -1 11/08/25, 22:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88717
-
core-ci voted on patch set 2 V +1 11/08/25, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88718
-
core-ci voted on patch set 3 V +1 11/08/25, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88719
-
Elias Häußler uploaded patch set 4
V +111/12/25, 09:05 -
Elias Häußler marked it ready for review 11/12/25, 09:05
-
core-ci voted on patch set 4 V +1 11/12/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89171
-
Oli Bartsch commented on patch set 4 V -1 11/12/25, 11:00
Unresolved
I need to fix preserving of module actions first. -
Elias Häußler rebased onto patch set 5
V +111/13/25, 20:10 -
core-ci voted on patch set 5 V -1 11/13/25, 20:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89583
-
Elias Häußler uploaded patch set 6
V -111/13/25, 20:34 -
core-ci voted on patch set 6 V +1 11/13/25, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89586
-
Oli Bartsch commented on patch set 6 11/13/25, 21:12
BreadcrumbFactory.php:210site -
Elias Häußler uploaded patch set 7
V +111/13/25, 21:35 -
Elias Häußler commented on patch set 7 11/13/25, 21:35
BreadcrumbFactory.php:210ReplyDone -
core-ci voted on patch set 7 V +1 11/13/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89598
-
Elias Häußler uploaded patch set 8
V +111/20/25, 14:28 -
core-ci voted on patch set 8 V +1 11/20/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90295
-
Georg Ringer voted on patch set 8 CR +1 V +1 11/20/25, 19:56
-
Benni Mack wrote 04/21/26, 14:53
Removed cc Benni Mack. -
Benni Mack uploaded patch set 9
CR +1V +110/16/26, 13:25 -
core-ci voted on patch set 9 V +1 10/16/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111361