Review 12.4 Merged

91576[TASK] Update PHPStan to 2.1.32

Garvin Hicking CR +2 V +2 Easy +6 −30 updated 11/12/25, 10:17

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.32 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

- ContentObjectRenderer dynamic method call with varying number
  of arguments and method existence is now ignored, as PHPStan
  complains about something that only reflection could solve,
  which is too impactful. This only affects main, because
  only there PHPStan is able to evaluate executed methods.

- RequestHandlerTest performed two useless assertions

- Dropped entries from baseline with false positives

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Garvin Hicking commented on patch set 1 11/12/25, 09:07

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php * typo3/sysext/frontend/Tests/Functional/SiteHandling/RequestHandlerTest.php
  2. Garvin Hicking uploaded patch set 2 11/12/25, 09:11

  3. core-ci voted on patch set 1 V -1 11/12/25, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89176

  4. core-ci voted on patch set 2 V -1 11/12/25, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89178

  5. Garvin Hicking uploaded patch set 3 V -1 11/12/25, 09:19

  6. Garvin Hicking marked it ready for review 11/12/25, 09:21

  7. core-ci voted on patch set 3 V +1 11/12/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89195

  8. Garvin Hicking updated the commit message in patch set 4 V +1 11/12/25, 09:30

  9. Oliver Klee voted on patch set 4 CR +1 11/12/25, 09:34

  10. Oliver Klee voted on patch set 4 V +1 11/12/25, 09:37

  11. core-ci voted on patch set 4 V +1 11/12/25, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89199

  12. Garvin Hicking voted on patch set 4 CR +2 V +2 11/12/25, 10:17

  13. Garvin Hicking merged patch set 5 11/12/25, 10:17