Review 13.4 Merged

91618[BUGFIX] Only encode the record title in workspace integrity messages

Andreas Nedbal CR +2 V +2 Easy +3 −3 updated 11/13/25, 15:45

Commit message

lit handles turning quotes into their respective HTML representations,
so encoding the messages fully leads to double encoding which shows
the integrity messages with """s.

To preserve security, we instead only apply htmlspecialchars() to the
record titles inside the integrity messages.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Andreas Nedbal commented on patch set 1 11/13/25, 14:18

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Service/GridDataService.php * typo3/sysext/workspaces/Classes/Service/IntegrityService.php
  2. Andreas Nedbal uploaded patch set 2 11/13/25, 14:40

  3. Andreas Nedbal marked it ready for review 11/13/25, 14:41

  4. core-ci voted on patch set 2 V +1 11/13/25, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89525

  5. core-ci voted on patch set 1 V -1 11/13/25, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89518

  6. core-ci voted on patch set 1 V -1 11/13/25, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89518

  7. Andreas Nedbal commented on patch set 2 11/13/25, 15:22

    The failing pipelines actually are the cherry pick timelines, the later passing one was quicker.
  8. Andreas Nedbal voted on patch set 2 CR +2 V +2 11/13/25, 15:45

  9. Andreas Nedbal merged patch set 3 11/13/25, 15:45