Review 13.4 Merged

91701[BUGFIX] Correct dom order after flatpicker initialization

Benjamin Kott CR +2 V +2 Easy +8 −1 updated 11/17/25, 07:37

Commit message

Flatpickr’s altInput feature inserts a hidden input
before the visible input, altering the expected DOM
structure within input groups. This causes the visible
input to no longer be the :first-child, which leads
CSS rules that unset the border-radius for non-first
inputs to affect it incorrectly.

The hidden input is now moved after the clearable
wrapper to restore the correct element order,
ensuring the visible input remains the first child
and its border-radius is not unset.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benjamin Kott commented on patch set 1 11/17/25, 07:26

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js
  2. Oli Bartsch uploaded patch set 2 11/17/25, 07:28

  3. Oli Bartsch commented on patch set 2 11/17/25, 07:31

    This change is ready for review.
  4. core-ci voted on patch set 2 V +1 11/17/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89903

  5. core-ci voted on patch set 1 V -1 11/17/25, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89902

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 11/17/25, 07:37

  7. Oli Bartsch merged patch set 3 11/17/25, 07:37