Review 13.4 Merged

91744[BUGFIX] Correct placement of form elements inside button groups

Benjamin Kott CR +2 V +2 Normal +54 −58 updated 11/19/25, 10:07

Commit message

Moves form elements with hidden input elements to be positioned before
their associated submit buttons within btn-group containers. This ensures
that CSS :first-child and :last-child selectors correctly target the
visible button elements for proper border-radius styling.

Additionally removes invalid nested btn-group elements inside input-group
containers, as buttons within input groups should be direct children
without an intermediate btn-group wrapper.

The forms containing only hidden input elements are not visually rendered
but were interfering with the visual styling when positioned after the
buttons.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. Benjamin Kott commented on patch set 1 11/19/25, 09:39

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/scheduler/Resources/Private/Partials/TaskList.fluid.html
  2. Benjamin Kott uploaded patch set 2 11/19/25, 09:48

  3. Benjamin Kott marked it ready for review 11/19/25, 09:49

  4. core-ci voted on patch set 1 V +1 11/19/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90114

  5. core-ci voted on patch set 2 V +1 11/19/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90116

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 11/19/25, 10:07

  7. Benjamin Kott merged patch set 3 11/19/25, 10:07